From: tip-bot for Mike Galbraith <efault@gmx.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
peterz@infradead.org, efault@gmx.de, arjan@infradead.org,
stable@kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/core] sched: Check for an idle shared cache in select_task_rq_fair()
Date: Wed, 4 Nov 2009 19:33:34 GMT [thread overview]
Message-ID: <tip-a1f84a3ab8e002159498814eaa7e48c33752b04b@git.kernel.org> (raw)
In-Reply-To: <1256654138.17752.7.camel@marge.simson.net>
Commit-ID: a1f84a3ab8e002159498814eaa7e48c33752b04b
Gitweb: http://git.kernel.org/tip/a1f84a3ab8e002159498814eaa7e48c33752b04b
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Tue, 27 Oct 2009 15:35:38 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 4 Nov 2009 18:46:22 +0100
sched: Check for an idle shared cache in select_task_rq_fair()
When waking affine, check for an idle shared cache, and if
found, wake to that CPU/sibling instead of the waker's CPU.
This improves pgsql+oltp ramp up by roughly 8%. Possibly more
for other loads, depending on overlap. The trade-off is a
roughly 1% peak downturn if tasks are truly synchronous.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: <stable@kernel.org>
LKML-Reference: <1256654138.17752.7.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched_fair.c | 33 +++++++++++++++++++++++++++++----
1 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 4e777b4..da87385 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1372,11 +1372,36 @@ static int select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flag
want_sd = 0;
}
- if (want_affine && (tmp->flags & SD_WAKE_AFFINE) &&
- cpumask_test_cpu(prev_cpu, sched_domain_span(tmp))) {
+ if (want_affine && (tmp->flags & SD_WAKE_AFFINE)) {
+ int candidate = -1, i;
- affine_sd = tmp;
- want_affine = 0;
+ if (cpumask_test_cpu(prev_cpu, sched_domain_span(tmp)))
+ candidate = cpu;
+
+ /*
+ * Check for an idle shared cache.
+ */
+ if (tmp->flags & SD_PREFER_SIBLING) {
+ if (candidate == cpu) {
+ if (!cpu_rq(prev_cpu)->cfs.nr_running)
+ candidate = prev_cpu;
+ }
+
+ if (candidate == -1 || candidate == cpu) {
+ for_each_cpu(i, sched_domain_span(tmp)) {
+ if (!cpu_rq(i)->cfs.nr_running) {
+ candidate = i;
+ break;
+ }
+ }
+ }
+ }
+
+ if (candidate >= 0) {
+ affine_sd = tmp;
+ want_affine = 0;
+ cpu = candidate;
+ }
}
if (!want_sd && !want_affine)
next prev parent reply other threads:[~2009-11-04 19:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 19:58 [PATCH 1/3] sched: Enable wake balancing for the SMT/HT domain Arjan van de Ven
2009-10-24 20:04 ` [PATCH 2/3] sched: Add aggressive load balancing for certain situations Arjan van de Ven
2009-10-24 20:07 ` [PATCH 3/3] sched: Disable affine wakeups by default Arjan van de Ven
2009-10-25 6:55 ` Mike Galbraith
2009-10-25 16:51 ` Arjan van de Ven
2009-10-25 17:38 ` Mike Galbraith
2009-10-25 19:33 ` Arjan van de Ven
2009-10-25 22:04 ` Mike Galbraith
2009-10-26 1:53 ` Peter Zijlstra
2009-10-26 4:38 ` Mike Galbraith
2009-10-26 4:52 ` Arjan van de Ven
2009-10-26 5:08 ` Mike Galbraith
2009-10-26 5:36 ` Arjan van de Ven
2009-10-26 5:47 ` Mike Galbraith
2009-10-26 5:57 ` Mike Galbraith
2009-10-26 7:01 ` Ingo Molnar
2009-10-26 7:05 ` Arjan van de Ven
2009-10-26 11:33 ` Suresh Siddha
2009-11-10 21:59 ` Peter Zijlstra
2009-11-11 6:01 ` Arjan van de Ven
2009-10-27 14:35 ` Mike Galbraith
2009-10-28 7:25 ` Mike Galbraith
2009-10-28 18:36 ` Mike Galbraith
2009-11-04 19:33 ` tip-bot for Mike Galbraith [this message]
2009-11-04 20:37 ` [tip:sched/core] sched: Check for an idle shared cache in select_task_rq_fair() Mike Galbraith
2009-11-04 21:41 ` Mike Galbraith
2009-11-05 9:30 ` Ingo Molnar
2009-11-05 9:57 ` Mike Galbraith
2009-11-05 10:00 ` Mike Galbraith
2009-11-06 7:09 ` [tip:sched/core] sched: Fix affinity logic " tip-bot for Mike Galbraith
2009-10-26 5:21 ` [PATCH 3/3] sched: Disable affine wakeups by default Mike Galbraith
2009-10-25 8:01 ` Peter Zijlstra
2009-10-25 8:01 ` [PATCH 2/3] sched: Add aggressive load balancing for certain situations Peter Zijlstra
2009-10-25 11:48 ` Peter Zijlstra
2009-10-25 8:03 ` [PATCH 1/3] sched: Enable wake balancing for the SMT/HT domain Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a1f84a3ab8e002159498814eaa7e48c33752b04b@git.kernel.org \
--to=efault@gmx.de \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox