linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	suresh.b.siddha@intel.com, tglx@linutronix.de, avi@redhat.com
Subject: [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives
Date: Wed, 12 May 2010 01:06:41 GMT	[thread overview]
Message-ID: <tip-a3c8acd04376d604370dcb6cd2143c9c14078a50@git.kernel.org> (raw)
In-Reply-To: <1273135546-29690-2-git-send-email-avi@redhat.com>

Commit-ID:  a3c8acd04376d604370dcb6cd2143c9c14078a50
Gitweb:     http://git.kernel.org/tip/a3c8acd04376d604370dcb6cd2143c9c14078a50
Author:     H. Peter Anvin <hpa@zytor.com>
AuthorDate: Tue, 11 May 2010 17:47:07 -0700
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 11 May 2010 17:47:07 -0700

x86: Add new static_cpu_has() function using alternatives

For CPU-feature-specific code that touches performance-critical paths,
introduce a static patching version of [boot_]cpu_has().  This is run
at alternatives time and is therefore not appropriate for most
initialization code, but on the other hand initialization code is
generally not performance critical.

On gcc 4.5+ this uses the new "asm goto" feature.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <1273135546-29690-2-git-send-email-avi@redhat.com>
---
 arch/x86/include/asm/cpufeature.h |   57 +++++++++++++++++++++++++++++++++++++
 1 files changed, 57 insertions(+), 0 deletions(-)

diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 0cd82d0..9b11a5c 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -175,6 +175,7 @@
 
 #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
 
+#include <asm/asm.h>
 #include <linux/bitops.h>
 
 extern const char * const x86_cap_flags[NCAPINTS*32];
@@ -283,6 +284,62 @@ extern const char * const x86_power_flags[32];
 
 #endif /* CONFIG_X86_64 */
 
+/*
+ * Static testing of CPU features.  Used the same as boot_cpu_has().
+ * These are only valid after alternatives have run, but will statically
+ * patch the target code for additional performance.
+ *
+ */
+static __always_inline __pure bool __static_cpu_has(u8 bit)
+{
+#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)
+		asm goto("1: jmp %l[t_no]\n"
+			 "2:\n"
+			 ".section .altinstructions,\"a\"\n"
+			 _ASM_ALIGN "\n"
+			 _ASM_PTR "1b\n"
+			 _ASM_PTR "0\n" 	/* no replacement */
+			 " .byte %P0\n"		/* feature bit */
+			 " .byte 2b - 1b\n"	/* source len */
+			 " .byte 0\n"		/* replacement len */
+			 " .byte 0xff + 0 - (2b-1b)\n"	/* padding */
+			 ".previous\n"
+			 : : "i" (bit) : : t_no);
+		return true;
+	t_no:
+		return false;
+#else
+		u8 flag;
+		/* Open-coded due to __stringify() in ALTERNATIVE() */
+		asm volatile("1: movb $0,%0\n"
+			     "2:\n"
+			     ".section .altinstructions,\"a\"\n"
+			     _ASM_ALIGN "\n"
+			     _ASM_PTR "1b\n"
+			     _ASM_PTR "3f\n"
+			     " .byte %P1\n"		/* feature bit */
+			     " .byte 2b - 1b\n"		/* source len */
+			     " .byte 4f - 3f\n"		/* replacement len */
+			     " .byte 0xff + (4f-3f) - (2b-1b)\n" /* padding */
+			     ".previous\n"
+			     ".section .altinstr_replacement,\"ax\"\n"
+			     "3: movb $1,%0\n"
+			     "4:\n"
+			     ".previous\n"
+			     : "=qm" (flag) : "i" (bit));
+		return flag;
+#endif
+}
+
+#define static_cpu_has(bit)					\
+(								\
+	__builtin_constant_p(boot_cpu_has(bit)) ?		\
+		boot_cpu_has(bit) :				\
+	(__builtin_constant_p(bit) && !((bit) & ~0xff)) ?	\
+		__static_cpu_has(bit) :				\
+		boot_cpu_has(bit)				\
+)
+
 #endif /* defined(__KERNEL__) && !defined(__ASSEMBLY__) */
 
 #endif /* _ASM_X86_CPUFEATURE_H */

  parent reply	other threads:[~2010-05-12  1:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  8:45 [PATCH v3 0/2] x86 FPU API Avi Kivity
2010-05-06  8:45 ` [PATCH v3 1/2] x86: eliminate TS_XSAVE Avi Kivity
2010-05-10 20:39   ` [tip:x86/fpu] x86: Eliminate TS_XSAVE tip-bot for Avi Kivity
2010-05-12  0:18   ` [tip:x86/fpu] x86, fpu: Use the proper asm constraint in use_xsave() tip-bot for H. Peter Anvin
2010-05-12  1:06   ` tip-bot for H. Peter Anvin [this message]
2010-05-18 20:10     ` [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives Eric Dumazet
2010-05-18 20:43       ` H. Peter Anvin
2010-05-18 20:57       ` H. Peter Anvin
2010-05-18 21:11         ` Eric Dumazet
2010-05-18 21:31           ` H. Peter Anvin
2010-05-18 21:38           ` Does anyone care about gcc 3.x support for x86 anymore? H. Peter Anvin
2010-05-19 23:10             ` Mauro Carvalho Chehab
2010-05-20  0:39               ` H. Peter Anvin
2010-05-20  0:42               ` H. Peter Anvin
2010-05-20 12:44                 ` Ingo Molnar
2010-05-18 20:58       ` [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives H. Peter Anvin
2010-05-18 21:31         ` Eric Dumazet
2010-05-27 20:12         ` [tip:x86/urgent] x86, cpufeature: Unbreak compile with gcc 3.x tip-bot for H. Peter Anvin
2010-05-12  1:06   ` [tip:x86/fpu] x86, fpu: Use static_cpu_has() to implement use_xsave() tip-bot for H. Peter Anvin
2010-05-06  8:45 ` [PATCH v3 2/2] x86: Introduce 'struct fpu' and related API Avi Kivity
2010-05-10 20:39   ` [tip:x86/fpu] " tip-bot for Avi Kivity
2010-05-10 20:40   ` [tip:x86/fpu] x86, fpu: Unbreak FPU emulation tip-bot for H. Peter Anvin
2010-05-10  8:48 ` [PATCH v3 0/2] x86 FPU API Avi Kivity
2010-05-10 15:24   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a3c8acd04376d604370dcb6cd2143c9c14078a50@git.kernel.org \
    --to=hpa@zytor.com \
    --cc=avi@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).