From: "tip-bot for H. Peter Anvin" <hpa@linux.intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, laijs@cn.fujitsu.com, hpa@linux.intel.com
Subject: [tip:x86/alternatives] x86, alternatives: correct obsolete use of "u8" in static_cpu_has()
Date: Tue, 29 Jun 2010 07:07:04 GMT [thread overview]
Message-ID: <tip-a3d2d12f275fcd33d7edc34e6b4112b5a3c9d35d@git.kernel.org> (raw)
In-Reply-To: <4C2474EF.4050902@cn.fujitsu.com>
Commit-ID: a3d2d12f275fcd33d7edc34e6b4112b5a3c9d35d
Gitweb: http://git.kernel.org/tip/a3d2d12f275fcd33d7edc34e6b4112b5a3c9d35d
Author: H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Mon, 28 Jun 2010 12:00:18 -0700
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 28 Jun 2010 22:04:47 -0700
x86, alternatives: correct obsolete use of "u8" in static_cpu_has()
gcc seems to pass unsigned words on as signed to the assembler, at
least with the %P format. As such, it is critical to get the correct
type.
Furthermore we are no longer limited to features < 256.
Reported-and-tested-by: Lai Jiangshan <laijs@cn.fujitsu.com>
LKML-Reference: <4C2474EF.4050902@cn.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/include/asm/cpufeature.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 66878c5..e8b8896 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -291,7 +291,7 @@ extern const char * const x86_power_flags[32];
* patch the target code for additional performance.
*
*/
-static __always_inline __pure bool __static_cpu_has(u8 bit)
+static __always_inline __pure bool __static_cpu_has(u16 bit)
{
#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)
asm goto("1: jmp %l[t_no]\n"
@@ -339,7 +339,7 @@ static __always_inline __pure bool __static_cpu_has(u8 bit)
( \
__builtin_constant_p(boot_cpu_has(bit)) ? \
boot_cpu_has(bit) : \
- (__builtin_constant_p(bit) && !((bit) & ~0xff)) ? \
+ __builtin_constant_p(bit) ? \
__static_cpu_has(bit) : \
boot_cpu_has(bit) \
)
next prev parent reply other threads:[~2010-06-29 7:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-*@git.kernel.org>
2009-12-12 0:16 ` [tip:x86/urgent] nvram: Fix write beyond end condition; prove to gcc copy is safe tip-bot for H. Peter Anvin
2009-12-15 23:18 ` [tip:x86/urgent] x86, msr/cpuid: Register enough minors for the MSR and CPUID drivers tip-bot for H. Peter Anvin
2010-02-19 6:21 ` [tip:x86/setup] x86-64, setup: Inhibit decompressor output if video info is invalid tip-bot for H. Peter Anvin
2010-02-19 21:41 ` [tip:x86/setup] x86, setup: Don't skip mode setting for the standard VGA modes tip-bot for H. Peter Anvin
2010-06-10 0:10 ` [tip:x86/alternatives] x86, alternatives: Use 16-bit numbers for cpufeature index tip-bot for H. Peter Anvin
2010-06-11 18:24 ` tip-bot for H. Peter Anvin
2010-06-25 9:20 ` Lai Jiangshan
2010-06-25 15:35 ` H. Peter Anvin
2010-06-28 7:58 ` Lai Jiangshan
2010-06-28 18:58 ` H. Peter Anvin
2010-06-28 19:06 ` H. Peter Anvin
2010-06-29 4:58 ` Lai Jiangshan
2010-06-29 7:07 ` tip-bot for H. Peter Anvin [this message]
2010-06-29 7:06 ` tip-bot for tip-bot for H. Peter Anvin
2010-06-29 9:15 ` Ingo Molnar
2010-06-29 15:33 ` H. Peter Anvin
2010-07-07 17:45 ` tip-bot for H. Peter Anvin
2010-07-20 2:06 ` [tip:x86/cpu] x86, cpu: Clean up formatting in cpufeature.h, remove override tip-bot for H. Peter Anvin
2010-07-20 2:06 ` [tip:x86/cpu] x86, cpu: Split addon_cpuid_features.c tip-bot for H. Peter Anvin
2010-08-12 6:12 ` [tip:x86/urgent] x86, asm: Refactor atomic64_386_32.S to support old binutils and be cleaner tip-bot for Luca Barbieri
2010-08-12 12:15 ` Luca Barbieri
2010-08-12 14:05 ` H. Peter Anvin
2010-08-12 15:18 ` Luca Barbieri
2010-08-12 15:33 ` [tip:x86/urgent] x86, asm: Use a lower case name for the end macro in atomic64_386_32.S tip-bot for Luca Barbieri
2010-08-19 19:06 ` [tip:x86/urgent] x86, asm: Refactor atomic64_386_32.S to support old binutils and be cleaner D. Stussy
2010-08-19 21:23 ` H. Peter Anvin
2010-08-20 8:21 ` Ingo Molnar
2010-08-25 0:37 ` [tip:x86/bios] x86, bios: By default, reserve the low 64K for all BIOSes tip-bot for H. Peter Anvin
2010-08-26 0:12 ` [tip:x86/bios] x86, bios: Make the x86 early memory reservation a kernel option tip-bot for H. Peter Anvin
2010-09-17 23:46 ` [tip:x86/idle] x86, mwait: Move mwait constants to a common header file tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a3d2d12f275fcd33d7edc34e6b4112b5a3c9d35d@git.kernel.org \
--to=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).