From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755226AbbFRMIg (ORCPT ); Thu, 18 Jun 2015 08:08:36 -0400 Received: from terminus.zytor.com ([198.137.202.10]:59703 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbbFRMI3 (ORCPT ); Thu, 18 Jun 2015 08:08:29 -0400 Date: Thu, 18 Jun 2015 05:08:00 -0700 From: tip-bot for Russell King Message-ID: Cc: tglx@linutronix.de, gnurou@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org, lee.jones@linaro.org, linus.walleij@linaro.org, hpa@zytor.com, rmk+kernel@arm.linux.org.uk, jason@lakedaemon.net, ulli.kroll@googlemail.com, thierry.reding@gmail.com Reply-To: rmk+kernel@arm.linux.org.uk, hpa@zytor.com, linus.walleij@linaro.org, mingo@kernel.org, linux-kernel@vger.kernel.org, lee.jones@linaro.org, gnurou@gmail.com, tglx@linutronix.de, thierry.reding@gmail.com, ulli.kroll@googlemail.com, jason@lakedaemon.net In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] gpio: gpio-mxs: Fix race in installing chained IRQ handler Git-Commit-ID: a44735f421b44724d52117358573f8ded473ecc7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a44735f421b44724d52117358573f8ded473ecc7 Gitweb: http://git.kernel.org/tip/a44735f421b44724d52117358573f8ded473ecc7 Author: Russell King AuthorDate: Tue, 16 Jun 2015 23:06:45 +0100 Committer: Thomas Gleixner CommitDate: Thu, 18 Jun 2015 14:03:08 +0200 gpio: gpio-mxs: Fix race in installing chained IRQ handler Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Signed-off-by: Russell King Cc: Alexandre Courbot Cc: Hans Ulli Kroll Cc: Jason Cooper Cc: Lee Jones Cc: Linus Walleij Cc: Thierry Reding Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/E1Z4z0H-0002Sf-P9@rmk-PC.arm.linux.org.uk Signed-off-by: Thomas Gleixner --- drivers/gpio/gpio-mxs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c index 84cbda6..eac8727 100644 --- a/drivers/gpio/gpio-mxs.c +++ b/drivers/gpio/gpio-mxs.c @@ -320,8 +320,8 @@ static int mxs_gpio_probe(struct platform_device *pdev) mxs_gpio_init_gc(port, irq_base); /* setup one handler for each entry */ - irq_set_chained_handler(port->irq, mxs_gpio_irq_handler); - irq_set_handler_data(port->irq, port); + irq_set_chained_handler_and_data(port->irq, mxs_gpio_irq_handler, + port); err = bgpio_init(&port->bgc, &pdev->dev, 4, port->base + PINCTRL_DIN(port),