From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, eranian@google.com, mingo@redhat.com,
mingo@kernel.org, a.p.zijlstra@chello.nl, efault@gmx.de,
jolsa@redhat.com, fweisbec@gmail.com, dsahern@gmail.com,
ak@linux.intel.com, tglx@linutronix.de, hpa@zytor.com,
paulus@samba.org, linux-kernel@vger.kernel.org,
namhyung@gmail.com, adrian.hunter@intel.com
Subject: [tip:perf/core] perf script: Fix symoff printing in callchains
Date: Wed, 11 Dec 2013 03:04:01 -0800 [thread overview]
Message-ID: <tip-a4eb24a49566db77ee999b46603f602a0302f481@git.kernel.org> (raw)
In-Reply-To: <1386315778-11633-2-git-send-email-adrian.hunter@intel.com>
Commit-ID: a4eb24a49566db77ee999b46603f602a0302f481
Gitweb: http://git.kernel.org/tip/a4eb24a49566db77ee999b46603f602a0302f481
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Fri, 6 Dec 2013 09:42:56 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 9 Dec 2013 11:13:50 -0300
perf script: Fix symoff printing in callchains
The address being used to calculate the offset was the memory address
but the address needed is the address mapped to the dso. i.e. the 'addr'
member of 'struct addr_location'
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1386315778-11633-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 8a7da6f..c236b38 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1515,6 +1515,8 @@ void perf_evsel__print_ip(struct perf_evsel *evsel, struct perf_sample *sample,
node_al = *al;
while (stack_depth) {
+ u64 addr = 0;
+
node = callchain_cursor_current(&callchain_cursor);
if (!node)
break;
@@ -1525,10 +1527,13 @@ void perf_evsel__print_ip(struct perf_evsel *evsel, struct perf_sample *sample,
if (print_ip)
printf("%c%16" PRIx64, s, node->ip);
+ if (node->map)
+ addr = node->map->map_ip(node->map, node->ip);
+
if (print_sym) {
printf(" ");
if (print_symoffset) {
- node_al.addr = node->ip;
+ node_al.addr = addr;
node_al.map = node->map;
symbol__fprintf_symname_offs(node->sym, &node_al, stdout);
} else
next prev parent reply other threads:[~2013-12-11 11:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 7:42 [PATCH V2 0/3] perf script: Add an option to print the source line number Adrian Hunter
2013-12-06 7:42 ` [PATCH V2 1/3] perf script: Fix symoff printing in callchains Adrian Hunter
2013-12-08 17:32 ` David Ahern
2013-12-11 11:04 ` tip-bot for Adrian Hunter [this message]
2013-12-06 7:42 ` [PATCH V2 2/3] perf script: Add an option to print the source line number Adrian Hunter
2013-12-08 17:35 ` David Ahern
2013-12-09 8:10 ` Adrian Hunter
2013-12-11 11:04 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-12-06 7:42 ` [PATCH V2 3/3] perf script: Improve srcline display for BTS Adrian Hunter
2013-12-09 18:04 ` Arnaldo Carvalho de Melo
2013-12-10 7:04 ` Adrian Hunter
2013-12-10 7:05 ` Adrian Hunter
2013-12-13 10:21 ` [PATCH V3] " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a4eb24a49566db77ee999b46603f602a0302f481@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox