From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbcBEL2d (ORCPT ); Fri, 5 Feb 2016 06:28:33 -0500 Received: from terminus.zytor.com ([198.137.202.10]:53072 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbcBEL2a (ORCPT ); Fri, 5 Feb 2016 06:28:30 -0500 Date: Fri, 5 Feb 2016 03:27:57 -0800 From: tip-bot for Prarit Bhargava Message-ID: Cc: tglx@linutronix.de, prarit@redhat.com, torvalds@linux-foundation.org, mingo@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, hpa@zytor.com Reply-To: peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, prarit@redhat.com, tglx@linutronix.de, torvalds@linux-foundation.org In-Reply-To: <1454596680-10367-1-git-send-email-prarit@redhat.com> References: <1454596680-10367-1-git-send-email-prarit@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/isolcpus: Output warning when the ' isolcpus=' kernel parameter is invalid Git-Commit-ID: a6e4491c682a7b28574a62e6f311a0acec50b318 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a6e4491c682a7b28574a62e6f311a0acec50b318 Gitweb: http://git.kernel.org/tip/a6e4491c682a7b28574a62e6f311a0acec50b318 Author: Prarit Bhargava AuthorDate: Thu, 4 Feb 2016 09:38:00 -0500 Committer: Ingo Molnar CommitDate: Fri, 5 Feb 2016 08:46:38 +0100 sched/isolcpus: Output warning when the 'isolcpus=' kernel parameter is invalid The isolcpus= kernel boot parameter restricts userspace from scheduling on the specified CPUs. If a CPU is specified that is outside the range of 0 to nr_cpu_ids, cpulist_parse() will return -ERANGE, return an empty cpulist, and fail silently. This patch adds an error message to isolated_cpu_setup() to indicate to the user that something has gone awry, and returns 0 on error. Signed-off-by: Prarit Bhargava Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1454596680-10367-1-git-send-email-prarit@redhat.com [ Twiddled some details. ] Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9503d59..24fcdbf 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6173,11 +6173,16 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu) /* Setup the mask of cpus configured for isolated domains */ static int __init isolated_cpu_setup(char *str) { + int ret; + alloc_bootmem_cpumask_var(&cpu_isolated_map); - cpulist_parse(str, cpu_isolated_map); + ret = cpulist_parse(str, cpu_isolated_map); + if (ret) { + pr_err("sched: Error, all isolcpus= values must be between 0 and %d\n", nr_cpu_ids); + return 0; + } return 1; } - __setup("isolcpus=", isolated_cpu_setup); struct s_data {