From: tip-bot for Oleg Nesterov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, ktkhai@parallels.com,
srikar@linux.vnet.ibm.com, ktkhai@odin.com, tglx@linutronix.de,
mingo@kernel.org, oleg@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [tip:sched/core] cpu/hotplug: Read_lock(tasklist_lock) doesn' t need to disable irqs
Date: Sun, 13 Sep 2015 03:56:47 -0700 [thread overview]
Message-ID: <tip-a75a6068dac25d4022ebcd82192ed6345407843c@git.kernel.org> (raw)
In-Reply-To: <20150910130750.GA20055@redhat.com>
Commit-ID: a75a6068dac25d4022ebcd82192ed6345407843c
Gitweb: http://git.kernel.org/tip/a75a6068dac25d4022ebcd82192ed6345407843c
Author: Oleg Nesterov <oleg@redhat.com>
AuthorDate: Thu, 10 Sep 2015 15:07:50 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 12 Sep 2015 11:54:27 +0200
cpu/hotplug: Read_lock(tasklist_lock) doesn't need to disable irqs
check_for_tasks() doesn't need to disable irqs, recursive
read_lock() from interrupt is fine.
While at it, s/do_each_thread/for_each_process_thread/.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Kirill Tkhai <ktkhai@odin.com>
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Kirill Tkhai <ktkhai@parallels.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150910130750.GA20055@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/cpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 82cf9df..050c634 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -304,8 +304,8 @@ static inline void check_for_tasks(int dead_cpu)
{
struct task_struct *g, *p;
- read_lock_irq(&tasklist_lock);
- do_each_thread(g, p) {
+ read_lock(&tasklist_lock);
+ for_each_process_thread(g, p) {
if (!p->on_rq)
continue;
/*
@@ -320,8 +320,8 @@ static inline void check_for_tasks(int dead_cpu)
pr_warn("Task %s (pid=%d) is on cpu %d (state=%ld, flags=%x)\n",
p->comm, task_pid_nr(p), dead_cpu, p->state, p->flags);
- } while_each_thread(g, p);
- read_unlock_irq(&tasklist_lock);
+ }
+ read_unlock(&tasklist_lock);
}
struct take_cpu_down_param {
prev parent reply other threads:[~2015-09-13 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 13:07 [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs Oleg Nesterov
2015-09-10 13:31 ` Kirill Tkhai
2015-09-11 10:24 ` Srikar Dronamraju
2015-09-13 10:56 ` tip-bot for Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a75a6068dac25d4022ebcd82192ed6345407843c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=ktkhai@odin.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox