Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early

Steven Rostedt
2017-05-16T22:50:23Z

On Wed, 17 May 2017 00:46:37 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> > > --- a/lib/smp_processor_id.c
> > > +++ b/lib/smp_processor_id.c
> > > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp
> > > /*
> > > * It is valid to assume CPU-locality during early bootup:
> > > */
> > > - if (system_state != SYSTEM_RUNNING)
> > > + if (system_state < SYSTEM_SCHEDULING)
> >
> > Do we want to ignore halting or rebooting too?
>
> I don't think so. After setting those states, interesting stuff like
> device_shutdown() gets invoked. We want the coverage there.

Then I'd suggest that you update the change log, as this patch also
adds coverage to those states as well.

-- Steve