public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org,
	eranian@google.com, paulus@samba.org, hpa@zytor.com,
	mingo@kernel.org, a.p.zijlstra@chello.nl, efault@gmx.de,
	namhyung@gmail.com, jolsa@redhat.com, fweisbec@gmail.com,
	adrian.hunter@intel.com, dsahern@gmail.com, tglx@linutronix.de
Subject: [tip:perf/urgent] perf machine: Fix path unpopulated in machine__create_modules()
Date: Wed, 25 Sep 2013 11:31:22 -0700	[thread overview]
Message-ID: <tip-aa7fe3b0c499fb7987245ac40295af03546f2bd2@git.kernel.org> (raw)
In-Reply-To: <1379845338-29637-2-git-send-email-adrian.hunter@intel.com>

Commit-ID:  aa7fe3b0c499fb7987245ac40295af03546f2bd2
Gitweb:     http://git.kernel.org/tip/aa7fe3b0c499fb7987245ac40295af03546f2bd2
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Sun, 22 Sep 2013 13:22:09 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 25 Sep 2013 12:48:24 -0300

perf machine: Fix path unpopulated in machine__create_modules()

In machine__create_modules() the 'path' char array was used in a call to
symbol__restricted_filename() without always being populated.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379845338-29637-2-git-send-email-adrian.hunter@intel.com
[ Split patch removing unrelated conversion of sprintf to snprintf to perf/core ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 933d14f..6188d28 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -792,7 +792,7 @@ static int machine__create_modules(struct machine *machine)
 		modules = path;
 	}
 
-	if (symbol__restricted_filename(path, "/proc/modules"))
+	if (symbol__restricted_filename(modules, "/proc/modules"))
 		return -1;
 
 	file = fopen(modules, "r");

  parent reply	other threads:[~2013-09-25 18:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-22 10:22 [PATCH V2 00/10] perf tools: kcore improvements Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 01/10] perf tools: fix path unpopulated in machine__create_modules() Adrian Hunter
2013-09-25 15:45   ` Arnaldo Carvalho de Melo
2013-09-25 18:31   ` tip-bot for Adrian Hunter [this message]
2013-10-15  5:28   ` [tip:perf/core] perf machine: Use snprintf instead of sprintf tip-bot for Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 02/10] perf tools: make a separate function to parse /proc/modules Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 03/10] perf tools: validate kcore module addresses Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 04/10] perf tools: workaround objdump difficulties with kcore Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 05/10] perf tools: add map__find_other_map_symbol() Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 06/10] perf tools: fix annotate_browser__callq() Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 07/10] perf tools: find kcore symbols on other maps Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 08/10] perf tools: add copyfile_mode() Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 09/10] perf buildid-cache: add ability to add kcore to the cache Adrian Hunter
2013-09-22 10:22 ` [PATCH V2 10/10] perf tools: add ability to find kcore in build-id cache Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-aa7fe3b0c499fb7987245ac40295af03546f2bd2@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox