From: tip-bot for Jason Wessel <jason.wessel@windriver.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
fweisbec@gmail.com, jason.wessel@windriver.com,
stable@kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] x86,kgdb: Always initialize the hw breakpoint attribute
Date: Fri, 2 Apr 2010 19:06:22 GMT [thread overview]
Message-ID: <tip-ab310b5edb8b601bcb02491ed6f7676da4fd1757@git.kernel.org> (raw)
In-Reply-To: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
Commit-ID: ab310b5edb8b601bcb02491ed6f7676da4fd1757
Gitweb: http://git.kernel.org/tip/ab310b5edb8b601bcb02491ed6f7676da4fd1757
Author: Jason Wessel <jason.wessel@windriver.com>
AuthorDate: Tue, 30 Mar 2010 14:05:07 -0500
Committer: Frederic Weisbecker <fweisbec@gmail.com>
CommitDate: Thu, 1 Apr 2010 08:26:32 +0200
x86,kgdb: Always initialize the hw breakpoint attribute
It is required to call hw_breakpoint_init() on an attr before using it
in any other calls. This fixes the problem where kgdb will sometimes
fail to initialize on x86_64.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: 2.6.33 <stable@kernel.org>
LKML-Reference: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
arch/x86/kernel/kgdb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index bfba601..b2258ca 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)
* portion of kgdb because this operation requires mutexs to
* complete.
*/
+ hw_breakpoint_init(&attr);
attr.bp_addr = (unsigned long)kgdb_arch_init;
- attr.type = PERF_TYPE_BREAKPOINT;
attr.bp_len = HW_BREAKPOINT_LEN_1;
attr.bp_type = HW_BREAKPOINT_W;
attr.disabled = 1;
prev parent reply other threads:[~2010-04-02 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 19:05 [PATCH 1/1] x86,kgdb: Always initialize the hw breakpoint attribute Jason Wessel
2010-03-30 19:15 ` Frederic Weisbecker
2010-04-02 19:06 ` tip-bot for Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ab310b5edb8b601bcb02491ed6f7676da4fd1757@git.kernel.org \
--to=jason.wessel@windriver.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox