Re: [PATCH V2 00/37] perf intel-pt: Power events and PTWRITE

Arnaldo Carvalho de Melo
2017-06-21T13:40:40Z

Em Wed, Jun 21, 2017 at 01:20:52PM +0300, Adrian Hunter escreveu:
> On 12/06/17 16:56, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jun 12, 2017 at 04:04:44PM +0300, Adrian Hunter escreveu:
> >> On 26/05/17 11:17, Adrian Hunter wrote:
> >>> Hi
> >>>
> >>> Here are some patches to support Intel PT Power events and PTWRITE.
> >>> Power events report changes to C-state but I have also added support
> >>> for the existing CBR (core-to-bus ratio) packet and included that
> >>> when outputting power events. The PTWRITE packet is associated with
> >>> the new ptwrite instruction, which is essentially just a way to stuff
> >>> a 32 or 64 bit value into the PT trace. More details can be found in
> >>> the patches that add documentation and in the Intel SDM.
> >>>
> >>> As far as I know, there isn't any hardware released that supports
> >>> the new packets, however the CBR packet is not new and will now be
> >>> visible by default.
> >>>
> >>> There are also some miscellaneous improvements to Intel PT.
> >>>
> >>> There are 3 patches that introduce a new way to define synthesized
> >>> events that carry arbitrary raw_data. I sent an RFC about that earlier.
> >>> The 3 patches are:
> >>> perf script: Add 'synth' event type for synthesized events
> >>> perf script: Add 'synth' field for synthesized event payloads
> >>> perf script: Add synthesized Intel PT power and ptwrite events
> >>>
> >>>
> >>> Changes in V2:
> >>>
> >>> Reorder patches and add stable tags to fixes.
> >>>
> >>
> >> Apart from "perf script: Add 'synth' event type for synthesized events"
> >> patches still apply. Any comments?
> >
> > I'll look at it today,
>
> I have sent V3 of two patches that did not now apply cleanly.

Thanks, I'm going thru that lot now, trying to understand the synth
event types handling in perf script, the ones affected by these
refreshed patches...

- Arnaldo