From: tip-bot for Arjan van de Ven <arjan@infradead.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org, hpa@zytor.com,
mingo@redhat.com, arjan@linux.intel.com, tglx@linutronix.de
Subject: [tip:timers/core] clockevents: Remove the per cpu tick skew
Date: Mon, 2 Aug 2010 19:48:47 GMT [thread overview]
Message-ID: <tip-af5ab277ded04bd9bc6b048c5a2f0e7d70ef0867@git.kernel.org> (raw)
In-Reply-To: <20100727210210.58d3118c@infradead.org>
Commit-ID: af5ab277ded04bd9bc6b048c5a2f0e7d70ef0867
Gitweb: http://git.kernel.org/tip/af5ab277ded04bd9bc6b048c5a2f0e7d70ef0867
Author: Arjan van de Ven <arjan@infradead.org>
AuthorDate: Tue, 27 Jul 2010 21:02:10 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 2 Aug 2010 21:45:58 +0200
clockevents: Remove the per cpu tick skew
Historically, Linux has tried to make the regular timer tick on the
various CPUs not happen at the same time, to avoid contention on
xtime_lock.
Nowadays, with the tickless kernel, this contention no longer happens
since time keeping and updating are done differently. In addition,
this skew is actually hurting power consumption in a measurable way on
many-core systems.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
LKML-Reference: <20100727210210.58d3118c@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/tick-sched.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 813993b..74644cc 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -780,7 +780,6 @@ void tick_setup_sched_timer(void)
{
struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
ktime_t now = ktime_get();
- u64 offset;
/*
* Emulate tick processing via per-CPU hrtimers:
@@ -790,10 +789,6 @@ void tick_setup_sched_timer(void)
/* Get the next period (per cpu) */
hrtimer_set_expires(&ts->sched_timer, tick_init_jiffy_update());
- offset = ktime_to_ns(tick_period) >> 1;
- do_div(offset, num_possible_cpus());
- offset *= smp_processor_id();
- hrtimer_add_expires_ns(&ts->sched_timer, offset);
for (;;) {
hrtimer_forward(&ts->sched_timer, now, tick_period);
prev parent reply other threads:[~2010-08-02 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 4:02 [patch] Remove the per cpu tick skew Arjan van de Ven
2010-07-28 20:26 ` john stultz
2010-07-28 23:50 ` john stultz
2010-07-30 7:27 ` Nick Piggin
2010-07-30 13:57 ` Arjan van de Ven
2010-08-02 19:48 ` tip-bot for Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-af5ab277ded04bd9bc6b048c5a2f0e7d70ef0867@git.kernel.org \
--to=arjan@infradead.org \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox