linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Jiang Liu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: cernekee@gmail.com, mingo@kernel.org, marc.zyngier@arm.com,
	arnd@arndb.de, jason@lakedaemon.net, bhelgaas@google.com,
	yinghai@kernel.org, jiang.liu@linux.intel.com,
	tony.luck@intel.com, konrad.wilk@oracle.com, tglx@linutronix.de,
	bp@alien8.de, rdunlap@infradead.org, benh@kernel.crashing.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: [tip:irq/urgent] genirq: Move field 'handler_data' from irq_data into irq_common_data
Date: Wed, 16 Sep 2015 13:56:22 -0700	[thread overview]
Message-ID: <tip-af7080e040d223b5e7d0a8de28f7cea24ef017c4@git.kernel.org> (raw)
In-Reply-To: <1433145945-789-13-git-send-email-jiang.liu@linux.intel.com>

Commit-ID:  af7080e040d223b5e7d0a8de28f7cea24ef017c4
Gitweb:     http://git.kernel.org/tip/af7080e040d223b5e7d0a8de28f7cea24ef017c4
Author:     Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Mon, 1 Jun 2015 16:05:21 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 16 Sep 2015 15:46:49 +0200

genirq: Move field 'handler_data' from irq_data into irq_common_data

Handler data (handler_data) is per-irq instead of per irqchip, so move
it into struct irq_common_data.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: http://lkml.kernel.org/r/1433145945-789-13-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/irq.h     | 8 ++++----
 include/linux/irqdesc.h | 2 +-
 kernel/irq/chip.c       | 4 ++--
 kernel/irq/irqdesc.c    | 3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index ebcc5c6..516aadb 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -130,12 +130,14 @@ struct irq_domain;
  * @state_use_accessors: status information for irq chip functions.
  *			Use accessor functions to deal with it
  * @node:		node index useful for balancing
+ * @handler_data:	per-IRQ data for the irq_chip methods
  */
 struct irq_common_data {
 	unsigned int		state_use_accessors;
 #ifdef CONFIG_NUMA
 	unsigned int		node;
 #endif
+	void			*handler_data;
 };
 
 /**
@@ -149,7 +151,6 @@ struct irq_common_data {
  *			between hwirq number and linux irq number.
  * @parent_data:	pointer to parent struct irq_data to support hierarchy
  *			irq_domain
- * @handler_data:	per-IRQ data for the irq_chip methods
  * @chip_data:		platform-specific per-chip private data for the chip
  *			methods, to allow shared chip implementations
  * @msi_desc:		MSI descriptor
@@ -165,7 +166,6 @@ struct irq_data {
 #ifdef	CONFIG_IRQ_DOMAIN_HIERARCHY
 	struct irq_data		*parent_data;
 #endif
-	void			*handler_data;
 	void			*chip_data;
 	struct msi_desc		*msi_desc;
 	cpumask_var_t		affinity;
@@ -641,12 +641,12 @@ static inline void *irq_data_get_irq_chip_data(struct irq_data *d)
 static inline void *irq_get_handler_data(unsigned int irq)
 {
 	struct irq_data *d = irq_get_irq_data(irq);
-	return d ? d->handler_data : NULL;
+	return d ? d->common->handler_data : NULL;
 }
 
 static inline void *irq_data_get_irq_handler_data(struct irq_data *d)
 {
-	return d->handler_data;
+	return d->common->handler_data;
 }
 
 static inline struct msi_desc *irq_get_msi_desc(unsigned int irq)
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
index 1fc5304..c7b3e1c 100644
--- a/include/linux/irqdesc.h
+++ b/include/linux/irqdesc.h
@@ -123,7 +123,7 @@ static inline void *irq_desc_get_chip_data(struct irq_desc *desc)
 
 static inline void *irq_desc_get_handler_data(struct irq_desc *desc)
 {
-	return desc->irq_data.handler_data;
+	return desc->irq_common_data.handler_data;
 }
 
 static inline struct msi_desc *irq_desc_get_msi_desc(struct irq_desc *desc)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6e40a95..a48e00e 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -83,7 +83,7 @@ int irq_set_handler_data(unsigned int irq, void *data)
 
 	if (!desc)
 		return -EINVAL;
-	desc->irq_data.handler_data = data;
+	desc->irq_common_data.handler_data = data;
 	irq_put_desc_unlock(desc, flags);
 	return 0;
 }
@@ -796,7 +796,7 @@ irq_set_chained_handler_and_data(unsigned int irq, irq_flow_handler_t handle,
 		return;
 
 	__irq_do_set_handler(desc, handle, 1, NULL);
-	desc->irq_data.handler_data = data;
+	desc->irq_common_data.handler_data = data;
 
 	irq_put_desc_busunlock(desc, flags);
 }
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 7f3e9fa..594b3e3 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -72,11 +72,12 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node,
 {
 	int cpu;
 
+	desc->irq_common_data.handler_data = NULL;
+
 	desc->irq_data.common = &desc->irq_common_data;
 	desc->irq_data.irq = irq;
 	desc->irq_data.chip = &no_irq_chip;
 	desc->irq_data.chip_data = NULL;
-	desc->irq_data.handler_data = NULL;
 	desc->irq_data.msi_desc = NULL;
 	irq_settings_clr_and_set(desc, ~0, _IRQ_DEFAULT_INIT_FLAGS);
 	irqd_set(&desc->irq_data, IRQD_IRQ_DISABLED);

  reply	other threads:[~2015-09-16 21:13 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  8:05 [Patch v3 00/36] Split struct irq_data into common part and per-chip part Jiang Liu
2015-06-01  8:05 ` [Patch v3 01/36] genirq: Enhance irq_data_to_desc() to support hierarchy irqdomain Jiang Liu
2015-06-16  8:16   ` [tip:x86/apic] " tip-bot for Jiang Liu
2015-06-20 17:18   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 02/36] genirq: Fix crash caused by irq_move_irq() when hierarch irqdomain is enabled Jiang Liu
2015-06-16  7:31   ` [tip:x86/apic] genirq: Prevent crash in irq_move_irq() tip-bot for Jiang Liu
2015-06-16  7:47     ` Jiang Liu
2015-06-16  8:12       ` Thomas Gleixner
2015-06-16  8:25         ` Jiang Liu
2015-06-16  8:16   ` tip-bot for Jiang Liu
2015-06-20 17:19   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 03/36] genirq: Introduce struct irq_common_data to host shared irq data Jiang Liu
2015-06-20 17:19   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 04/36] genirq: Introduce helper function irq_data_get_node() Jiang Liu
2015-06-20 17:19   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 05/36] x86, irq: Use accessor irq_data_get_node() to hide struct irq_data detail Jiang Liu
2015-06-01  8:05 ` [Patch v3 06/36] sh, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 07/36] genirq: Move field 'node' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:56   ` [tip:irq/urgent] genirq: Move field 'node' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 08/36] sparc, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details Jiang Liu
2015-07-31 21:53   ` [tip:irq/core] sparc/irq: Use helper irq_data_get_irq_handler_data() tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 09/36] x86, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details Jiang Liu
2015-06-01  8:05 ` [Patch v3 10/36] " Jiang Liu
2015-06-01  8:05 ` [Patch v3 11/36] sh, " Jiang Liu
2015-06-01 11:38   ` Sergei Shtylyov
2015-06-01 13:53     ` Jiang Liu
2015-06-01  8:05 ` [Patch v3 12/36] genirq: Move field 'handler_data' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:56   ` tip-bot for Jiang Liu [this message]
2015-06-01  8:05 ` [Patch v3 13/36] mn10300: Fix incorrect use of data->affinity Jiang Liu
2015-06-26 19:49   ` [tip:irq/urgent] mn10300: Fix incorrect use of irq_data->affinity tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 14/36] genirq: Introduce helper function irq_data_get_affinity_mask() Jiang Liu
2015-06-20 17:19   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 15/36] alpha, irq: Use access helper irq_data_get_affinity_mask() Jiang Liu
2015-06-01  8:05 ` [Patch v3 16/36] ARM, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 17/36] ARM64, " Jiang Liu
2015-06-02  6:25   ` Hanjun Guo
2015-06-01  8:05 ` [Patch v3 18/36] blackfin, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 19/36] IA64, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 20/36] metag, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 21/36] mips, " Jiang Liu
2015-06-05  8:46   ` Ralf Baechle
2015-06-01  8:05 ` [Patch v3 22/36] mn10300, " Jiang Liu
2015-07-31 21:53   ` [tip:irq/core] mn10300/irq: " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 23/36] parisc, irq: " Jiang Liu
2015-07-31 21:53   ` [tip:irq/core] parisc/irq: " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 24/36] powerpc, irq: " Jiang Liu
2015-09-15 15:47   ` [tip:irq/urgent] " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 25/36] sh, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 26/36] sparc, " Jiang Liu
2015-07-31 21:54   ` [tip:irq/core] sparc/irq: " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 27/36] x86, irq: " Jiang Liu
2015-06-02 19:19   ` Thomas Gleixner
2015-06-03  1:53     ` Jiang Liu
2015-06-03  3:46     ` Jiang Liu
2015-06-01  8:05 ` [Patch v3 28/36] xtensa, " Jiang Liu
2015-06-01  8:05 ` [Patch v3 29/36] irqchip, " Jiang Liu
2015-07-11 21:38   ` [tip:irq/core] irqchip/mips-gic: " tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 30/36] net/mlx4: Cache irq_desc->affinity instead of irq_desc Jiang Liu
2015-06-01  8:05 ` [Patch v3 31/36] genirq: Move field 'affinity' from struct irq_data into struct irq_common_data Jiang Liu
2015-06-03  3:47   ` Jiang Liu
2015-09-16 20:56     ` [tip:irq/urgent] genirq: Move field 'affinity' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 32/36] genirq: Rename irq_data_get_msi() as irq_data_get_msi_desc() Jiang Liu
2015-06-01  8:05 ` [Patch v3 33/36] genirq: Use helper function to access irq_data->msi_desc Jiang Liu
2015-06-02  3:45   ` [v3,33/36] " Michael Ellerman
2015-06-02  5:46     ` Jiang Liu
2015-06-03 16:53     ` Thomas Gleixner
2015-06-01  8:05 ` [Patch v3 34/36] genirq: Move field 'msi_desc' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:57   ` [tip:irq/urgent] genirq: Move field 'msi_desc' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01  8:05 ` [Patch v3 35/36] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked() Jiang Liu
2015-06-05  8:48   ` Ralf Baechle
2015-06-01  8:05 ` [Patch v3 36/36] genirq: Optimize irq_data_to_desc() to avoid irq_to_desc() lookup Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-af7080e040d223b5e7d0a8de28f7cea24ef017c4@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=cernekee@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=jiang.liu@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).