[tip:perf/core] perf top: Default to system wide using perf_target methods

tip-bot for Arnaldo Carvalho de Melo
2012-05-11T06:45:06Z

Commit-ID: 80eebd94d2090cf9e13ecdc305a0cf7996fa0070
Gitweb: http://git.kernel.org/tip/80eebd94d2090cf9e13ecdc305a0cf7996fa0070
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Tue, 8 May 2012 10:47:09 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 8 May 2012 10:47:09 -0300

perf top: Default to system wide using perf_target methods

Additionally we were not checking if a cpu list had been provided by the
user. Fix that.

Reported-by: David Ahern <dsahern@gmail.com>
Reported-by: Namhyung Kim <namhyung@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-ao3zrouylwmt7h9ikj0krubi@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index e4ca827..c53cdab 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1270,8 +1270,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __used)
goto out_delete_evlist;
}

- if (top.target.tid == 0 && top.target.pid == 0 &&
- top.target.uid_str == NULL)
+ if (perf_target__none(&top.target))
top.target.system_wide = true;

if (perf_evlist__create_maps(top.evlist, &top.target) < 0)