From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, eranian@google.com, jolsa@kernel.org,
ak@linux.intel.com, tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, acme@redhat.com
Subject: [tip:perf/core] perf stat: Handled scaled == -1 case for counters
Date: Sat, 20 Feb 2016 03:35:43 -0800 [thread overview]
Message-ID: <tip-b002f3bbd321993c1a6d56b86544065420156ab9@git.kernel.org> (raw)
In-Reply-To: <1455749045-18098-2-git-send-email-andi@firstfloor.org>
Commit-ID: b002f3bbd321993c1a6d56b86544065420156ab9
Gitweb: http://git.kernel.org/tip/b002f3bbd321993c1a6d56b86544065420156ab9
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Wed, 17 Feb 2016 14:44:00 -0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 19 Feb 2016 19:12:45 -0300
perf stat: Handled scaled == -1 case for counters
Arnaldo pointed out that the earlier cb110f471025 ("perf stat: Move
noise/running printing into printout") change changed behavior for not
counted counters. This patch fixes it again.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Fixes: cb110f471025 ("perf stat: Move noise/running printing into printout")
Link: http://lkml.kernel.org/r/1455749045-18098-2-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 15e4fcf..86289df 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -860,7 +860,7 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
nl = new_line_std;
- if (run == 0 || ena == 0) {
+ if (run == 0 || ena == 0 || counter->counts->scaled == -1) {
aggr_printout(counter, id, nr);
fprintf(stat_config.output, "%*s%s",
next prev parent reply other threads:[~2016-02-20 11:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 22:43 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-17 22:44 ` [PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters Andi Kleen
2016-02-20 11:35 ` tip-bot for Andi Kleen [this message]
2016-02-17 22:44 ` [PATCH 2/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-02-18 17:00 ` Arnaldo Carvalho de Melo
2016-02-18 17:39 ` Andi Kleen
2016-02-21 16:39 ` Jiri Olsa
2016-02-22 16:26 ` Andi Kleen
2016-02-21 16:39 ` Jiri Olsa
2016-02-17 22:44 ` [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-02-21 17:15 ` Jiri Olsa
2016-02-22 16:52 ` Andi Kleen
2016-02-23 7:37 ` Jiri Olsa
2016-02-21 17:18 ` Jiri Olsa
2016-02-21 17:22 ` Jiri Olsa
2016-02-26 23:53 ` Andi Kleen
2016-02-17 22:44 ` [PATCH 4/6] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-02-17 22:44 ` [PATCH 5/6] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-02-17 22:44 ` [PATCH 6/6] perf, tools, stat: Add --metric-only support for -A Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b002f3bbd321993c1a6d56b86544065420156ab9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).