From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, peterz@infradead.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org, mingo@kernel.org,
alexander.shishkin@linux.intel.com, acme@redhat.com,
tglx@linutronix.de, namhyung@kernel.org
Subject: [tip:perf/core] perf header: Fix wrong node write in NUMA_TOPOLOGY feature
Date: Wed, 27 Feb 2019 23:37:48 -0800 [thread overview]
Message-ID: <tip-b00ccb27f97367d89e2d7b419ed198b0985be55d@git.kernel.org> (raw)
In-Reply-To: <20190219095815.15931-2-jolsa@kernel.org>
Commit-ID: b00ccb27f97367d89e2d7b419ed198b0985be55d
Gitweb: https://git.kernel.org/tip/b00ccb27f97367d89e2d7b419ed198b0985be55d
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Tue, 19 Feb 2019 10:58:12 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 19 Feb 2019 12:20:55 -0300
perf header: Fix wrong node write in NUMA_TOPOLOGY feature
We are currently passing the node index instead of the real node number.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: fbe96f29ce4b ("perf tools: Make perf.data more self-descriptive (v8)"
Link: http://lkml.kernel.org/r/20190219095815.15931-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 61ce197c5362..c66f26ec557a 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -879,7 +879,7 @@ static int write_numa_topology(struct feat_fd *ff,
if (ret < 0)
break;
- ret = write_topo_node(ff, i);
+ ret = write_topo_node(ff, j);
if (ret < 0)
break;
}
next prev parent reply other threads:[~2019-02-28 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 9:58 [PATCHv3 0/4] perf tools: Assorted fixes Jiri Olsa
2019-02-19 9:58 ` [PATCH 1/4] perf header: Fix wrong node write in NUMA_TOPOLOGY feature Jiri Olsa
2019-02-28 7:37 ` tip-bot for Jiri Olsa [this message]
2019-02-19 9:58 ` [PATCH 2/4] perf tools: Add cpu_topology object Jiri Olsa
2019-02-28 7:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2019-02-19 9:58 ` [PATCH 3/4] perf tools: Add numa_topology object Jiri Olsa
2019-02-28 7:39 ` [tip:perf/core] " tip-bot for Jiri Olsa
2019-02-19 9:58 ` [PATCH 4/4] perf tools: Use sysfs__mountpoint() when reading cpu topology Jiri Olsa
2019-02-28 7:39 ` [tip:perf/core] " tip-bot for Jiri Olsa
2019-02-19 14:28 ` [PATCHv3 0/4] perf tools: Assorted fixes Namhyung Kim
2019-02-19 15:21 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b00ccb27f97367d89e2d7b419ed198b0985be55d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox