From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdFEJIr (ORCPT ); Mon, 5 Jun 2017 05:08:47 -0400 Received: from terminus.zytor.com ([65.50.211.136]:50009 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdFEJIp (ORCPT ); Mon, 5 Jun 2017 05:08:45 -0400 Date: Mon, 5 Jun 2017 02:04:04 -0700 From: tip-bot for Ben Hutchings Message-ID: Cc: peterz@infradead.org, sasha.levin@oracle.com, ben@decadent.org.uk, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, tglx@linutronix.de Reply-To: peterz@infradead.org, sasha.levin@oracle.com, hpa@zytor.com, ben@decadent.org.uk, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, torvalds@linux-foundation.org In-Reply-To: <20170525130005.5947-7-alexander.levin@verizon.com> References: <20170525130005.5947-7-alexander.levin@verizon.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] tools/lib/lockdep: Fix 'set but not used' warnings Git-Commit-ID: b016d870cadae31d7c5eb2eef794d2e733f6595c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b016d870cadae31d7c5eb2eef794d2e733f6595c Gitweb: http://git.kernel.org/tip/b016d870cadae31d7c5eb2eef794d2e733f6595c Author: Ben Hutchings AuthorDate: Thu, 25 May 2017 12:58:38 +0000 Committer: Ingo Molnar CommitDate: Mon, 5 Jun 2017 09:28:06 +0200 tools/lib/lockdep: Fix 'set but not used' warnings liblockdep defines trivial macros for working with interrupt flags, as interrupts are never disabled in userland. This results in warnings from gcc when -Wunused-but-set-variable is enabled, and it is enabled by -Wall. Fix this by evaluating the flags parameter and casting it to void. Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: a.p.zijlstra@chello.nl Link: http://lkml.kernel.org/r/20170525130005.5947-7-alexander.levin@verizon.com Signed-off-by: Ingo Molnar --- tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/lib/lockdep/uinclude/linux/irqflags.h b/tools/lib/lockdep/uinclude/linux/irqflags.h index 6cc296f..df77669 100644 --- a/tools/lib/lockdep/uinclude/linux/irqflags.h +++ b/tools/lib/lockdep/uinclude/linux/irqflags.h @@ -17,19 +17,19 @@ #define raw_local_irq_disable() do { } while (0) #define raw_local_irq_enable() do { } while (0) #define raw_local_irq_save(flags) ((flags) = 0) -#define raw_local_irq_restore(flags) do { } while (0) +#define raw_local_irq_restore(flags) ((void)(flags)) #define raw_local_save_flags(flags) ((flags) = 0) -#define raw_irqs_disabled_flags(flags) do { } while (0) +#define raw_irqs_disabled_flags(flags) ((void)(flags)) #define raw_irqs_disabled() 0 #define raw_safe_halt() #define local_irq_enable() do { } while (0) #define local_irq_disable() do { } while (0) #define local_irq_save(flags) ((flags) = 0) -#define local_irq_restore(flags) do { } while (0) +#define local_irq_restore(flags) ((void)(flags)) #define local_save_flags(flags) ((flags) = 0) #define irqs_disabled() (1) -#define irqs_disabled_flags(flags) (0) +#define irqs_disabled_flags(flags) ((void)(flags), 0) #define safe_halt() do { } while (0) #define trace_lock_release(x, y)