From: tip-bot for Rusty Russell <rusty@rustcorp.com.au>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
yinghai@kernel.org, torvalds@linux-foundation.org,
rusty@rustcorp.com.au, jbarnes@virtuousgeek.org, gregkh@suse.de,
tj@kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Remove redundant non-NUMA topology functions
Date: Thu, 24 Sep 2009 12:18:52 GMT [thread overview]
Message-ID: <tip-b0c6fbe458183cc7e1cab17be6efcbe7e435bad3@git.kernel.org> (raw)
In-Reply-To: <200909241748.45629.rusty@rustcorp.com.au>
Commit-ID: b0c6fbe458183cc7e1cab17be6efcbe7e435bad3
Gitweb: http://git.kernel.org/tip/b0c6fbe458183cc7e1cab17be6efcbe7e435bad3
Author: Rusty Russell <rusty@rustcorp.com.au>
AuthorDate: Thu, 24 Sep 2009 17:48:44 +0930
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 24 Sep 2009 14:16:15 +0200
x86: Remove redundant non-NUMA topology functions
arch/x86/include/asm/topology.h declares inline fns cpu_to_node and
cpumask_of_node for !NUMA, even though they are then declared as
macros by asm-generic/topology.h, which is #included just below.
The macros (which are the same) end up being used; these functions
are just confusing.
Noticed-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
LKML-Reference: <200909241748.45629.rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/topology.h | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 6f0695d..25a9284 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -165,21 +165,11 @@ static inline int numa_node_id(void)
return 0;
}
-static inline int cpu_to_node(int cpu)
-{
- return 0;
-}
-
static inline int early_cpu_to_node(int cpu)
{
return 0;
}
-static inline const struct cpumask *cpumask_of_node(int node)
-{
- return cpu_online_mask;
-}
-
static inline void setup_node_to_cpumask_map(void) { }
#endif
next prev parent reply other threads:[~2009-09-24 12:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 20:21 [git pull] first round of PCI updates for 2.6.32 Jesse Barnes
2009-09-16 14:55 ` Linus Torvalds
2009-09-16 15:20 ` Stephen Rothwell
2009-09-17 17:30 ` Ingo Molnar
2009-09-17 17:36 ` Jesse Barnes
2009-09-17 17:59 ` Ingo Molnar
2009-09-17 18:46 ` Jesse Barnes
2009-09-18 7:59 ` [crash] BUG: unable to handle kernel NULL pointer dereference at (null), last sysfs file: /sys/devices/pci0000:00/0000:00:01.0/local_cpus Ingo Molnar
2009-09-18 9:37 ` David Rientjes
2009-09-18 15:38 ` Linus Torvalds
2009-09-18 15:44 ` Jesse Barnes
2009-09-24 8:18 ` Rusty Russell
2009-09-24 12:18 ` tip-bot for Rusty Russell [this message]
2009-09-18 16:24 ` Yinghai Lu
2009-09-18 16:34 ` Jesse Barnes
2009-09-18 16:51 ` Linus Torvalds
2009-09-18 17:10 ` Jesse Barnes
2009-09-18 15:27 ` [git pull] first round of PCI updates for 2.6.32 Jesse Barnes
2009-09-18 15:52 ` Ingo Molnar
2009-09-18 16:17 ` Jesse Barnes
2009-09-17 17:45 ` Yinghai Lu
2009-09-17 18:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b0c6fbe458183cc7e1cab17be6efcbe7e435bad3@git.kernel.org \
--to=rusty@rustcorp.com.au \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox