From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de,
acme@redhat.com, hpa@zytor.com, mingo@kernel.org,
dsahern@gmail.com, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl
Subject: [tip:perf/core] perf hists browser: Save perf_session_env in the hist_browser
Date: Tue, 5 May 2015 20:21:23 -0700 [thread overview]
Message-ID: <tip-b1a9ceef724341ce05b125d39abf9cfc7059b949@git.kernel.org> (raw)
In-Reply-To: <1429687101-4360-7-git-send-email-namhyung@kernel.org>
Commit-ID: b1a9ceef724341ce05b125d39abf9cfc7059b949
Gitweb: http://git.kernel.org/tip/b1a9ceef724341ce05b125d39abf9cfc7059b949
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Wed, 22 Apr 2015 16:18:17 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 5 May 2015 18:13:17 -0300
perf hists browser: Save perf_session_env in the hist_browser
The perf_session_env is to save system informantion at the recording
time to be refered in the hist browser. So it'd be better to keep in
the struct hist_browser. This is a preparation to later change.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429687101-4360-7-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 26d5548..45704d6 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -27,6 +27,7 @@ struct hist_browser {
struct map_symbol *selection;
struct hist_browser_timer *hbt;
struct pstack *pstack;
+ struct perf_session_env *env;
int print_seq;
bool show_dso;
bool show_headers;
@@ -1198,7 +1199,8 @@ static int hist_browser__dump(struct hist_browser *browser)
}
static struct hist_browser *hist_browser__new(struct hists *hists,
- struct hist_browser_timer *hbt)
+ struct hist_browser_timer *hbt,
+ struct perf_session_env *env)
{
struct hist_browser *browser = zalloc(sizeof(*browser));
@@ -1210,6 +1212,7 @@ static struct hist_browser *hist_browser__new(struct hists *hists,
browser->b.use_navkeypressed = true;
browser->show_headers = symbol_conf.show_hist_headers;
browser->hbt = hbt;
+ browser->env = env;
}
return browser;
@@ -1425,7 +1428,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
struct perf_session_env *env)
{
struct hists *hists = evsel__hists(evsel);
- struct hist_browser *browser = hist_browser__new(hists, hbt);
+ struct hist_browser *browser = hist_browser__new(hists, hbt, env);
struct branch_info *bi;
#define MAX_OPTIONS 16
char *options[MAX_OPTIONS];
next prev parent reply other threads:[~2015-05-06 3:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 7:18 [PATCHSET 00/10] perf tools: Assorted cleanup for TUI (v3) Namhyung Kim
2015-04-22 7:18 ` [PATCH 01/10] perf tools: Move TUI-specific fields into unnamed union Namhyung Kim
2015-04-22 11:57 ` Arnaldo Carvalho de Melo
2015-05-06 3:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 02/10] perf tools: Move init_have_children field to the " Namhyung Kim
2015-05-06 3:20 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 03/10] perf hists browser: Fix possible memory leak Namhyung Kim
2015-05-06 3:20 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 04/10] perf hists browser: Save hist_browser_timer pointer in hist_browser Namhyung Kim
2015-05-06 3:20 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 05/10] perf hists browser: Save pstack in the hist_browser Namhyung Kim
2015-05-06 3:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 06/10] perf hists browser: Save perf_session_env " Namhyung Kim
2015-05-06 3:21 ` tip-bot for Namhyung Kim [this message]
2015-04-22 7:18 ` [PATCH 07/10] perf hists browser: Split popup menu actions Namhyung Kim
2015-05-06 3:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 08/10] perf hists browser: Split popup menu actions - part 2 Namhyung Kim
2015-04-22 10:54 ` Jiri Olsa
2015-04-22 13:03 ` Namhyung Kim
2015-04-22 13:25 ` Arnaldo Carvalho de Melo
2015-04-22 13:32 ` Namhyung Kim
2015-04-22 13:41 ` Jiri Olsa
2015-04-22 13:53 ` Namhyung Kim
2015-04-22 14:02 ` Jiri Olsa
2015-05-06 3:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 09/10] perf hists browser: Simplify zooming code a bit Namhyung Kim
2015-04-23 22:30 ` Arnaldo Carvalho de Melo
2015-04-24 1:15 ` [PATCH v2 9/10] perf tools: Introduce pstack_peek() Namhyung Kim
2015-04-24 1:15 ` [PATCH v2 9.5/10] perf hists browser: Simplify zooming code using pstack_peek() Namhyung Kim
2015-05-06 3:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-05-06 3:22 ` [tip:perf/core] perf tools: Introduce pstack_peek() tip-bot for Namhyung Kim
2015-04-22 7:18 ` [PATCH 10/10] perf tools: Move TUI-specific fields out of map_symbol Namhyung Kim
2015-04-27 17:20 ` Arnaldo Carvalho de Melo
2015-04-28 7:30 ` Namhyung Kim
2015-04-28 12:29 ` Arnaldo Carvalho de Melo
2015-05-04 15:42 ` Arnaldo Carvalho de Melo
2015-05-04 15:51 ` Arnaldo Carvalho de Melo
2015-05-05 1:12 ` Namhyung Kim
2015-05-05 14:07 ` Arnaldo Carvalho de Melo
2015-05-05 14:22 ` Namhyung Kim
2015-05-05 1:18 ` [PATCH v2 " Namhyung Kim
2015-05-05 14:22 ` Arnaldo Carvalho de Melo
2015-05-05 14:26 ` Arnaldo Carvalho de Melo
2015-05-05 14:40 ` Namhyung Kim
2015-05-05 14:55 ` [PATCH v3 " Namhyung Kim
2015-05-05 16:00 ` Arnaldo Carvalho de Melo
2015-05-06 3:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-04-22 11:12 ` [PATCHSET 00/10] perf tools: Assorted cleanup for TUI (v3) Jiri Olsa
2015-04-22 13:05 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b1a9ceef724341ce05b125d39abf9cfc7059b949@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).