From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932857AbcLGS0m (ORCPT ); Wed, 7 Dec 2016 13:26:42 -0500 Received: from terminus.zytor.com ([198.137.202.10]:53746 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbcLGS0l (ORCPT ); Wed, 7 Dec 2016 13:26:41 -0500 Date: Wed, 7 Dec 2016 10:26:08 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: minchan@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, peterz@infradead.org, dsahern@gmail.com, acme@redhat.com, mingo@kernel.org, andi@firstfloor.org, hpa@zytor.com, tglx@linutronix.de, jolsa@kernel.org Reply-To: minchan@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, dsahern@gmail.com, peterz@infradead.org, acme@redhat.com, mingo@kernel.org, andi@firstfloor.org, hpa@zytor.com, tglx@linutronix.de, jolsa@kernel.org In-Reply-To: <20161206034010.6499-6-namhyung@kernel.org> References: <20161206034010.6499-6-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf sched timehist: Cleanup idle_max_cpu handling Git-Commit-ID: b336352b417edd8c058c9e09d136728b6e2ff56d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b336352b417edd8c058c9e09d136728b6e2ff56d Gitweb: http://git.kernel.org/tip/b336352b417edd8c058c9e09d136728b6e2ff56d Author: Namhyung Kim AuthorDate: Tue, 6 Dec 2016 12:40:05 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 7 Dec 2016 12:00:34 -0300 perf sched timehist: Cleanup idle_max_cpu handling It treats the idle_max_cpu little bit confusingly IMHO. Let's make it more straight forward. Signed-off-by: Namhyung Kim Acked-by: David Ahern Cc: Andi Kleen Cc: Jiri Olsa Cc: Minchan Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20161206034010.6499-6-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-sched.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index c8b3e6c..1a3f1be 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -2010,7 +2010,7 @@ static int init_idle_threads(int ncpu) if (!idle_threads) return -ENOMEM; - idle_max_cpu = ncpu - 1; + idle_max_cpu = ncpu; /* allocate the actual thread struct if needed */ for (i = 0; i < ncpu; ++i) { @@ -2031,7 +2031,7 @@ static void free_idle_threads(void) if (idle_threads == NULL) return; - for (i = 0; i <= idle_max_cpu; ++i) { + for (i = 0; i < idle_max_cpu; ++i) { if ((idle_threads[i])) thread__delete(idle_threads[i]); } @@ -2054,8 +2054,7 @@ static struct thread *get_idle_thread(int cpu) return NULL; idle_threads = (struct thread **) p; - i = idle_max_cpu ? idle_max_cpu + 1 : 0; - for (; i < j; ++i) + for (i = idle_max_cpu; i < j; ++i) idle_threads[i] = NULL; idle_max_cpu = j; @@ -2495,7 +2494,7 @@ static void timehist_print_summary(struct perf_sched *sched, return; printf("\nIdle stats:\n"); - for (i = 0; i <= idle_max_cpu; ++i) { + for (i = 0; i < idle_max_cpu; ++i) { t = idle_threads[i]; if (!t) continue;