* [tip:perf/urgent] perf/x86/intel/pt: Fix a refactoring bug
@ 2015-06-04 14:14 tip-bot for Alexander Shishkin
0 siblings, 0 replies; only message in thread
From: tip-bot for Alexander Shishkin @ 2015-06-04 14:14 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, linux-kernel, torvalds, tglx, alexander.shishkin,
tvrtko.ursulin, imre.deak, akpm, mingo, hpa
Commit-ID: b44a2b53becf2485f484bd6bb6c1d963ebc339f8
Gitweb: http://git.kernel.org/tip/b44a2b53becf2485f484bd6bb6c1d963ebc339f8
Author: Alexander Shishkin <alexander.shishkin@linux.intel.com>
AuthorDate: Thu, 4 Jun 2015 16:31:47 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 4 Jun 2015 16:07:51 +0200
perf/x86/intel/pt: Fix a refactoring bug
Commit 066450be41 ("perf/x86/intel/pt: Clean up the control flow
in pt_pmu_hw_init()") changed attribute initialization so that
only the first attribute gets initialized using
sysfs_attr_init(), which upsets lockdep.
This patch fixes the glitch so that all allocated attributes are
properly initialized thus fixing the lockdep warning reported by
Tvrtko and Imre.
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Reported-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_intel_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index 5b804f9..123ff1b 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -151,7 +151,7 @@ static int __init pt_pmu_hw_init(void)
de_attr->attr.attr.name = pt_caps[i].name;
- sysfs_attr_init(&de_attrs->attr.attr);
+ sysfs_attr_init(&de_attr->attr.attr);
de_attr->attr.attr.mode = S_IRUGO;
de_attr->attr.show = pt_cap_show;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-04 14:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-04 14:14 [tip:perf/urgent] perf/x86/intel/pt: Fix a refactoring bug tip-bot for Alexander Shishkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox