From: tip-bot for Thomas Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de,
vincent.weaver@maine.edu, eranian@google.com, hpa@zytor.com,
torvalds@linux-foundation.org, acme@redhat.com
Subject: [tip:perf/core] perf/core: Remove bogus UP_CANCELED hotplug state
Date: Wed, 17 Feb 2016 04:24:10 -0800 [thread overview]
Message-ID: <tip-b4f75d44bed1bdbb14ac704bfc38f62a3675e591@git.kernel.org> (raw)
In-Reply-To: <20160209201007.682184765@linutronix.de>
Commit-ID: b4f75d44bed1bdbb14ac704bfc38f62a3675e591
Gitweb: http://git.kernel.org/tip/b4f75d44bed1bdbb14ac704bfc38f62a3675e591
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 9 Feb 2016 20:11:20 +0000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 17 Feb 2016 10:37:28 +0100
perf/core: Remove bogus UP_CANCELED hotplug state
If CPU_UP_PREPARE fails the perf hotplug code calls perf_event_exit_cpu(),
which is a pointless exercise. The cpu is not online, so the smp function
calls return -ENXIO. So the result is a list walk to call noops.
Remove it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/20160209201007.682184765@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/events/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5946460..474ffea 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9286,7 +9286,6 @@ perf_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu)
perf_event_init_cpu(cpu);
break;
- case CPU_UP_CANCELED:
case CPU_DOWN_PREPARE:
perf_event_exit_cpu(cpu);
break;
next prev parent reply other threads:[~2016-02-17 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 20:11 [patch 0/4] perf: Fix various cpu hotplug oddities Thomas Gleixner
2016-02-09 20:11 ` [patch 1/4] perf: Remove bogus UP_CANCELED hotplug state Thomas Gleixner
2016-02-17 12:24 ` tip-bot for Thomas Gleixner [this message]
2016-02-09 20:11 ` [patch 2/4] perf: Remove the bogus and dangerous CPU_DOWN_FAILED " Thomas Gleixner
2016-02-17 12:24 ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner
2016-02-09 20:11 ` [patch 3/4] perf: Plug potential memory leak in CPU_UP_PREPARE Thomas Gleixner
2016-02-17 12:24 ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner
2016-02-09 20:11 ` [patch 4/4] perf: Remove unused arguments from a bunch of functions Thomas Gleixner
2016-02-17 12:25 ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b4f75d44bed1bdbb14ac704bfc38f62a3675e591@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).