From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbdJCRqq (ORCPT ); Tue, 3 Oct 2017 13:46:46 -0400 Received: from terminus.zytor.com ([65.50.211.136]:60311 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdJCRqn (ORCPT ); Tue, 3 Oct 2017 13:46:43 -0400 Date: Tue, 3 Oct 2017 10:43:08 -0700 From: tip-bot for Masami Hiramatsu Message-ID: Cc: mhiramat@kernel.org, rostedt@goodmis.org, ananth@linux.vnet.ibm.com, mingo@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, ast@kernel.org, ast@fb.com, paulmck@linux.vnet.ibm.com, hpa@zytor.com, tglx@linutronix.de, peterz@infradead.org Reply-To: mhiramat@kernel.org, peterz@infradead.org, tglx@linutronix.de, hpa@zytor.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, ast@kernel.org, ast@fb.com, rostedt@goodmis.org, ananth@linux.vnet.ibm.com, mingo@kernel.org, torvalds@linux-foundation.org In-Reply-To: <150701508194.32266.14458959863314097305.stgit@devbox> References: <150701508194.32266.14458959863314097305.stgit@devbox> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] kprobes/x86: Remove IRQ disabling from jprobe handlers Git-Commit-ID: b664d57f39d01e775204d4f1a7e2f8bda77bc549 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b664d57f39d01e775204d4f1a7e2f8bda77bc549 Gitweb: https://git.kernel.org/tip/b664d57f39d01e775204d4f1a7e2f8bda77bc549 Author: Masami Hiramatsu AuthorDate: Tue, 3 Oct 2017 16:18:02 +0900 Committer: Ingo Molnar CommitDate: Tue, 3 Oct 2017 19:11:48 +0200 kprobes/x86: Remove IRQ disabling from jprobe handlers Jprobes actually don't need to disable IRQs while calling handlers, because of how we specify the kernel interface in Documentation/kprobes.txt: ----- Probe handlers are run with preemption disabled. Depending on the architecture and optimization state, handlers may also run with interrupts disabled (e.g., kretprobe handlers and optimized kprobe handlers run without interrupt disabled on x86/x86-64). ----- So let's remove IRQ disabling from jprobes too. Signed-off-by: Masami Hiramatsu Cc: Alexei Starovoitov Cc: Alexei Starovoitov Cc: Ananth N Mavinakayanahalli Cc: Linus Torvalds Cc: Paul E . McKenney Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/150701508194.32266.14458959863314097305.stgit@devbox Signed-off-by: Ingo Molnar --- arch/x86/kernel/kprobes/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index f015371..0742491 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -1080,8 +1080,6 @@ int setjmp_pre_handler(struct kprobe *p, struct pt_regs *regs) * raw stack chunk with redzones: */ __memcpy(kcb->jprobes_stack, (kprobe_opcode_t *)addr, MIN_STACK_SIZE(addr)); - regs->flags &= ~X86_EFLAGS_IF; - trace_hardirqs_off(); regs->ip = (unsigned long)(jp->entry); /*