From: tip-bot for Jeremy Fitzhardinge <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
konrad.wilk@oracle.com, jeremy@goop.org,
raghavendra.kt@linux.vnet.ibm.com, tglx@linutronix.de,
hpa@linux.intel.com, attilio.rao@citrix.com
Subject: [tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions
Date: Sat, 10 Aug 2013 09:13:38 -0700 [thread overview]
Message-ID: <tip-b798df09f919c52823110a74bd568c6a4e98e6b2@git.kernel.org> (raw)
In-Reply-To: <1376058122-8248-4-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
Commit-ID: b798df09f919c52823110a74bd568c6a4e98e6b2
Gitweb: http://git.kernel.org/tip/b798df09f919c52823110a74bd568c6a4e98e6b2
Author: Jeremy Fitzhardinge <jeremy@goop.org>
AuthorDate: Fri, 9 Aug 2013 19:51:51 +0530
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Fri, 9 Aug 2013 07:53:14 -0700
x86, ticketlock: Collapse a layer of functions
Now that the paravirtualization layer doesn't exist at the spinlock
level any more, we can collapse the __ticket_ functions into the arch_
functions.
Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Link: http://lkml.kernel.org/r/1376058122-8248-4-git-send-email-raghavendra.kt@linux.vnet.ibm.com
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tested-by: Attilio Rao <attilio.rao@citrix.com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/include/asm/spinlock.h | 35 +++++------------------------------
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index 4d54244..7442410 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -76,7 +76,7 @@ static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock,
* in the high part, because a wide xadd increment of the low part would carry
* up and contaminate the high part.
*/
-static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
+static __always_inline void arch_spin_lock(struct arch_spinlock *lock)
{
register struct __raw_tickets inc = { .tail = 1 };
@@ -96,7 +96,7 @@ static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
out: barrier(); /* make sure nothing creeps before the lock is taken */
}
-static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
+static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
{
arch_spinlock_t old, new;
@@ -110,7 +110,7 @@ static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
return cmpxchg(&lock->head_tail, old.head_tail, new.head_tail) == old.head_tail;
}
-static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
+static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
{
__ticket_t next = lock->tickets.head + 1;
@@ -118,46 +118,21 @@ static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
__ticket_unlock_kick(lock, next);
}
-static inline int __ticket_spin_is_locked(arch_spinlock_t *lock)
+static inline int arch_spin_is_locked(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return tmp.tail != tmp.head;
}
-static inline int __ticket_spin_is_contended(arch_spinlock_t *lock)
+static inline int arch_spin_is_contended(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return (__ticket_t)(tmp.tail - tmp.head) > 1;
}
-
-static inline int arch_spin_is_locked(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_locked(lock);
-}
-
-static inline int arch_spin_is_contended(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_contended(lock);
-}
#define arch_spin_is_contended arch_spin_is_contended
-static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
-{
- __ticket_spin_lock(lock);
-}
-
-static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
-{
- return __ticket_spin_trylock(lock);
-}
-
-static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
-{
- __ticket_spin_unlock(lock);
-}
-
static __always_inline void arch_spin_lock_flags(arch_spinlock_t *lock,
unsigned long flags)
{
next prev parent reply other threads:[~2013-08-10 16:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 14:21 [PATCH V13 00/14] Paravirtualized ticket spinlocks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 01/14] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2013-08-10 16:13 ` [tip:x86/spinlocks] x86, spinlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 02/14] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2013-08-10 16:13 ` [tip:x86/spinlocks] x86, ticketlock: Don' t " tip-bot for Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 03/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-10 16:13 ` tip-bot for Jeremy Fitzhardinge [this message]
2013-08-09 14:21 ` [PATCH V13 04/14] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2013-08-10 16:13 ` [tip:x86/spinlocks] " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 05/14] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2013-08-10 16:13 ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 06/14] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2013-08-10 16:14 ` [tip:x86/spinlocks] xen, pvticketlocks: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 07/14] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2013-08-10 16:14 ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 08/14] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2013-08-10 16:14 ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 09/14] jump_label: Split jumplabel ratelimit Raghavendra K T
2013-08-10 16:14 ` [tip:x86/spinlocks] " tip-bot for Andrew Jones
2013-08-09 14:21 ` [PATCH V13 10/14] x86/ticketlock: Add slowpath logic Raghavendra K T
2013-08-10 16:14 ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:21 ` [PATCH V13 11/14] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2013-08-10 16:15 ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-09 14:22 ` [PATCH V13 12/14] kvm uapi: Add KICK_CPU and PV_UNHALT definition to uapi Raghavendra K T
2013-08-10 16:15 ` [tip:x86/spinlocks] " tip-bot for Raghavendra K T
2013-08-09 14:22 ` [PATCH V13 13/14] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2013-08-10 16:15 ` [tip:x86/spinlocks] kvm guest: " tip-bot for Srivatsa Vaddagiri
2013-08-09 14:22 ` [PATCH V13 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2013-08-10 16:15 ` [tip:x86/spinlocks] kvm: " tip-bot for Srivatsa Vaddagiri
2013-08-10 19:38 ` [PATCH RESEND V13 14/14] kvm : " Raghavendra K T
2013-08-12 17:27 ` [tip:x86/spinlocks] kvm: " tip-bot for Srivatsa Vaddagiri
2013-08-13 16:42 ` [PATCH RESEND V13 14/14] kvm : " H. Peter Anvin
2013-08-13 16:55 ` Ingo Molnar
2013-08-13 20:02 ` [PATCH delta " Raghavendra K T
2013-08-13 20:00 ` Jeremy Fitzhardinge
2013-08-13 20:27 ` Raghavendra K T
2013-08-14 9:50 ` Raghavendra K T
2013-08-14 12:49 ` [tip:x86/spinlocks] kvm: " tip-bot for Srivatsa Vaddagiri
2013-08-11 5:35 ` [PATCH RESEND V13 14/14] kvm : " Raghavendra K T
-- strict thread matches above, loose matches on Subject: below --
2013-08-06 11:41 [PATCH V12 3/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b798df09f919c52823110a74bd568c6a4e98e6b2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=attilio.rao@citrix.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).