From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: eranian@google.com, mingo@kernel.org, tglx@linutronix.de,
hpa@zytor.com, linux-kernel@vger.kernel.org, ak@linux.intel.com,
jolsa@kernel.org, acme@redhat.com
Subject: [tip:perf/core] perf tools: Do not include escape sequences in color_vfprintf return
Date: Thu, 6 Aug 2015 00:03:41 -0700 [thread overview]
Message-ID: <tip-b7a001d2067830a98e65d1bbbf99a6d435d70616@git.kernel.org> (raw)
In-Reply-To: <1438649408-20807-3-git-send-email-andi@firstfloor.org>
Commit-ID: b7a001d2067830a98e65d1bbbf99a6d435d70616
Gitweb: http://git.kernel.org/tip/b7a001d2067830a98e65d1bbbf99a6d435d70616
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Mon, 3 Aug 2015 17:50:02 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 5 Aug 2015 16:46:06 -0300
perf tools: Do not include escape sequences in color_vfprintf return
color_vprintf was including the length of the invisible escape sequences
in its return argument. Don't include them to make the return value
usable for indentation calculations.
v2: Add comment, rebase
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1438649408-20807-3-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/color.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c
index ff051d2..9b95654 100644
--- a/tools/perf/util/color.c
+++ b/tools/perf/util/color.c
@@ -67,6 +67,7 @@ static int __color_vsnprintf(char *bf, size_t size, const char *color,
return r;
}
+/* Colors are not included in return value */
static int __color_vfprintf(FILE *fp, const char *color, const char *fmt,
va_list args)
{
@@ -83,10 +84,10 @@ static int __color_vfprintf(FILE *fp, const char *color, const char *fmt,
}
if (perf_use_color_default && *color)
- r += fprintf(fp, "%s", color);
+ fprintf(fp, "%s", color);
r += vfprintf(fp, fmt, args);
if (perf_use_color_default && *color)
- r += fprintf(fp, "%s", PERF_COLOR_RESET);
+ fprintf(fp, "%s", PERF_COLOR_RESET);
return r;
}
next prev parent reply other threads:[~2015-08-06 7:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 0:50 perf, tools: Refactor and support interval and CSV metrics v2 Andi Kleen
2015-08-04 0:50 ` [PATCH 1/8] perf, tools: Remove trail argument to color vsprintf Andi Kleen
2015-08-06 7:03 ` [tip:perf/core] perf " tip-bot for Jiri Olsa
2015-08-04 0:50 ` [PATCH 2/8] perf, tools: Do not include escape sequences in color_vfprintf return Andi Kleen
2015-08-06 7:03 ` tip-bot for Andi Kleen [this message]
2015-08-04 0:50 ` [PATCH 3/8] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-08-04 0:50 ` [PATCH 4/8] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-08-04 0:50 ` [PATCH 5/8] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-08-04 0:50 ` [PATCH 6/8] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-08-04 0:50 ` [PATCH 7/8] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-08-04 0:50 ` [PATCH 8/8] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-08-05 7:34 ` perf, tools: Refactor and support interval and CSV metrics v2 Jiri Olsa
2015-08-05 15:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b7a001d2067830a98e65d1bbbf99a6d435d70616@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox