[PATCH -tip] perf report: Fix segmentation fault when running with '-g none'

[PATCH -tip] perf report: Fix segmentation fault when running with '-g none'

[Yong Wang]

Segmentation fault occurs when running perf report with '-g none':

Starting program: /root/perf report -g none

Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? ()
(gdb) bt
#0  0x00000000 in ?? ()
#1  0x0808fbb9 in perf_session__insert_output_hist_entry (
    min_callchain_hits=<value optimized out>, he=<value optimized out>,
    root=<value optimized out>) at util/hist.c:169
#2  perf_session__output_resort (min_callchain_hits=<value optimized out>,
    he=<value optimized out>, root=<value optimized out>) at util/hist.c:204
#3  0x080575e9 in __cmd_report () at builtin-report.c:228
#4  cmd_report () at builtin-report.c:385
#5  0x0804b528 in run_builtin (p=0x8146b88, argc=3, argv=0xbffff818)
    at perf.c:263
#6  0x0804bd0b in handle_internal_command (argv=<value optimized out>,
    argc=<value optimized out>) at perf.c:328
#7  run_argv (argv=<value optimized out>, argc=<value optimized out>)
    at perf.c:372
#8  main (argv=<value optimized out>, argc=<value optimized out>) at perf.c:456

Reported-by: Austin Zhang <austin.zhang@intel.com>
Signed-off-by: Yong Wang <yong.y.wang@intel.com>

---
 tools/perfbuiltin-report.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 4c3d699..cfc655d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -279,7 +279,7 @@ parse_callchain_opt(const struct option *opt __used, const char *arg,
 
 	else if (!strncmp(tok, "none", strlen(arg))) {
 		callchain_param.mode = CHAIN_NONE;
-		symbol_conf.use_callchain = true;
+		symbol_conf.use_callchain = false;
 
 		return 0;
 	}

[tip:perf/urgent] perf report: Fix segmentation fault when running with '-g none'

[tip-bot for Yong Wang]

Commit-ID:  b7ae11b34bf042cfb4dbaa3b63b2d5d6d33d4cc4
Gitweb:     http://git.kernel.org/tip/b7ae11b34bf042cfb4dbaa3b63b2d5d6d33d4cc4
Author:     Yong Wang <yong.y.wang@linux.intel.com>
AuthorDate: Fri, 22 Jan 2010 09:47:50 +0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 27 Jan 2010 11:01:43 +0100

perf report: Fix segmentation fault when running with '-g none'

Segmentation fault occurs when running perf report with '-g
none'.

Reported-by: Austin Zhang <austin.zhang@intel.com>
Signed-off-by: Yong Wang <yong.y.wang@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20100122014750.GA4111@ywang-moblin2.bj.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/builtin-report.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index db10c0e..860f1ee 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -269,7 +269,7 @@ parse_callchain_opt(const struct option *opt __used, const char *arg,
 
 	else if (!strncmp(tok, "none", strlen(arg))) {
 		callchain_param.mode = CHAIN_NONE;
-		symbol_conf.use_callchain = true;
+		symbol_conf.use_callchain = false;
 
 		return 0;
 	}