[PATCH] perf_event: missing field in PERF_RECORD_SAMPLE documentation

[PATCH] perf_event: missing field in PERF_RECORD_SAMPLE documentation

[Vince Weaver]

While trying to write a perf_event/mmap test for my perf_event 
test-suite I came across a missing field description in the 
PERF_RECORD_SAMPLE documentation.

Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>

diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 4f63c05..9fa9c62 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -579,7 +579,8 @@ enum perf_event_type {
 	 *	{ u32			size;
 	 *	  char                  data[size];}&& PERF_SAMPLE_RAW
 	 *
-	 *	{ u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
+	 *	{ u64                   nr;
+	 *        { u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
 	 *
 	 * 	{ u64			abi; # enum perf_sample_regs_abi
 	 * 	  u64			regs[weight(mask)]; } && PERF_SAMPLE_REGS_USER

[PATCH] perf_event: missing field in PERF_RECORD_SAMPLE documentation (resend)

[Vince Weaver]

I sent this in November with no response, but the patch still 
applies.

While trying to write a perf_event/mmap test for my perf_event 
test-suite I came across a missing field description in the 
PERF_RECORD_SAMPLE documentation in perf_event.h
 
Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>

diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 4f63c05..9fa9c62 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -579,7 +579,8 @@ enum perf_event_type {
 	 *	{ u32			size;
 	 *	  char                  data[size];}&& PERF_SAMPLE_RAW
 	 *
-	 *	{ u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
+	 *	{ u64                   nr;
+	 *        { u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
 	 *
 	 * 	{ u64			abi; # enum perf_sample_regs_abi
 	 * 	  u64			regs[weight(mask)]; } && PERF_SAMPLE_REGS_USER

Re: [PATCH] perf_event: missing field in PERF_RECORD_SAMPLE documentation (resend)

[Arnaldo Carvalho de Melo]

Em Tue, Jan 08, 2013 at 02:44:25PM -0500, Vince Weaver escreveu:
> I sent this in November with no response, but the patch still 
> applies.
> 
> While trying to write a perf_event/mmap test for my perf_event 
> test-suite I came across a missing field description in the 
> PERF_RECORD_SAMPLE documentation in perf_event.h

Thanks, applied to my perf/core branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux

- Arnaldo

[tip:perf/core] perf: Missing field in PERF_RECORD_SAMPLE documentation

[tip-bot for Vince Weaver]

Commit-ID:  b878e7fb22ea48b0585bbbbef249f7efc6d42748
Gitweb:     http://git.kernel.org/tip/b878e7fb22ea48b0585bbbbef249f7efc6d42748
Author:     Vince Weaver <vincent.weaver@maine.edu>
AuthorDate: Tue, 8 Jan 2013 14:44:25 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 24 Jan 2013 16:40:19 -0300

perf: Missing field in PERF_RECORD_SAMPLE documentation

While trying to write a perf_event/mmap test for my perf_event
test-suite I came across a missing field description in the
PERF_RECORD_SAMPLE documentation in perf_event.h

Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1301081439300.24507@vincent-weaver-1.um.maine.edu
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 include/uapi/linux/perf_event.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 4f63c05..9fa9c62 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -579,7 +579,8 @@ enum perf_event_type {
 	 *	{ u32			size;
 	 *	  char                  data[size];}&& PERF_SAMPLE_RAW
 	 *
-	 *	{ u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
+	 *	{ u64                   nr;
+	 *        { u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
 	 *
 	 * 	{ u64			abi; # enum perf_sample_regs_abi
 	 * 	  u64			regs[weight(mask)]; } && PERF_SAMPLE_REGS_USER