From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750982AbcHJSBE (ORCPT ); Wed, 10 Aug 2016 14:01:04 -0400 Received: from terminus.zytor.com ([198.137.202.10]:55814 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbcHJSBC (ORCPT ); Wed, 10 Aug 2016 14:01:02 -0400 Date: Wed, 10 Aug 2016 11:00:30 -0700 From: tip-bot for Xunlei Pang Message-ID: Cc: torvalds@linux-foundation.org, tglx@linutronix.de, khlebnikov@yandex-team.ru, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, xlpang@redhat.com, peterz@infradead.org Reply-To: peterz@infradead.org, xlpang@redhat.com, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, khlebnikov@yandex-team.ru, torvalds@linux-foundation.org In-Reply-To: <1468050862-18864-1-git-send-email-xlpang@redhat.com> References: <1468050862-18864-1-git-send-email-xlpang@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/fair: Fix typo in sync_throttle() Git-Commit-ID: b8922125e4790fa237a8a4204562ecf457ef54bb X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b8922125e4790fa237a8a4204562ecf457ef54bb Gitweb: http://git.kernel.org/tip/b8922125e4790fa237a8a4204562ecf457ef54bb Author: Xunlei Pang AuthorDate: Sat, 9 Jul 2016 15:54:22 +0800 Committer: Ingo Molnar CommitDate: Wed, 10 Aug 2016 13:32:55 +0200 sched/fair: Fix typo in sync_throttle() We should update cfs_rq->throttled_clock_task, not pcfs_rq->throttle_clock_task. The effects of this bug was probably occasionally erratic group scheduling, particularly in cgroups-intense workloads. Signed-off-by: Xunlei Pang [ Added changelog. ] Signed-off-by: Peter Zijlstra (Intel) Acked-by: Konstantin Khlebnikov Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: 55e16d30bd99 ("sched/fair: Rework throttle_count sync") Link: http://lkml.kernel.org/r/1468050862-18864-1-git-send-email-xlpang@redhat.com Signed-off-by: Ingo Molnar --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 4088eed..039de34 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu) pcfs_rq = tg->parent->cfs_rq[cpu]; cfs_rq->throttle_count = pcfs_rq->throttle_count; - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); } /* conditionally throttle active cfs_rq's from put_prev_entity() */