From: tip-bot for Pavel Tatashin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: pasha.tatashin@oracle.com, hpa@zytor.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: [tip:x86/timers] timekeeping: Warning when persistent clock is not available
Date: Mon, 30 Jul 2018 04:48:52 -0700 [thread overview]
Message-ID: <tip-b8becb6ca494ddb84f5752ecdb6d56ae49d9ab8a@git.kernel.org> (raw)
In-Reply-To: <20180725200018.23722-1-pasha.tatashin@oracle.com>
Commit-ID: b8becb6ca494ddb84f5752ecdb6d56ae49d9ab8a
Gitweb: https://git.kernel.org/tip/b8becb6ca494ddb84f5752ecdb6d56ae49d9ab8a
Author: Pavel Tatashin <pasha.tatashin@oracle.com>
AuthorDate: Wed, 25 Jul 2018 16:00:18 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 30 Jul 2018 13:45:20 +0200
timekeeping: Warning when persistent clock is not available
On arches with no persistent clock a message like this is printed during
boot:
[ 0.000000] Persistent clock returned invalid value
The value is not invalid: it simply zero meaning no persistent clock and
the absence of persistent clock should be quietly accepted.
Fixes: 3eca993740b8 ("timekeeping: Replace read_boot_clock64() with read_persistent_wall_and_boot_offset()")
Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: steven.sistare@oracle.com
Cc: daniel.m.jordan@oracle.com
Cc: sboyd@kernel.org
Cc: john.stultz@linaro.org
Link: https://lkml.kernel.org/r/20180725200018.23722-1-pasha.tatashin@oracle.com
---
kernel/time/timekeeping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 30d7f64ffc87..6183e7460138 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1536,7 +1536,7 @@ void __init timekeeping_init(void)
if (timespec64_valid_strict(&wall_time) &&
timespec64_to_ns(&wall_time) > 0) {
persistent_clock_exists = true;
- } else {
+ } else if (timespec64_to_ns(&wall_time) != 0) {
pr_warn("Persistent clock returned invalid value");
wall_time = (struct timespec64){0};
}
next prev parent reply other threads:[~2018-07-30 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 20:00 [PATCH] timekeeping: warning when persistent clock is not available Pavel Tatashin
2018-07-30 11:48 ` tip-bot for Pavel Tatashin [this message]
2018-07-30 17:36 ` [tip:x86/timers] timekeeping: Prevent false " tip-bot for Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b8becb6ca494ddb84f5752ecdb6d56ae49d9ab8a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox