From: tip-bot for Andy Shevchenko <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, andriy.shevchenko@linux.intel.com,
david.e.box@linux.intel.com, mingo@kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: [tip:x86/platform] x86/platform/iosf_mbi: Remove NULL pointer checks for pci_dev_put()
Date: Thu, 16 Jul 2015 08:53:08 -0700 [thread overview]
Message-ID: <tip-b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff@git.kernel.org> (raw)
In-Reply-To: <1436366709-17683-4-git-send-email-andriy.shevchenko@linux.intel.com>
Commit-ID: b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff
Gitweb: http://git.kernel.org/tip/b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Wed, 8 Jul 2015 17:45:07 +0300
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 16 Jul 2015 17:48:48 +0200
x86/platform/iosf_mbi: Remove NULL pointer checks for pci_dev_put()
pci_dev_put() has already a check for NULL pointer.
[ tglx: Massaged changelog ]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David E . Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1436366709-17683-4-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/platform/intel/iosf_mbi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c
index 2362da9..0b33105 100644
--- a/arch/x86/platform/intel/iosf_mbi.c
+++ b/arch/x86/platform/intel/iosf_mbi.c
@@ -314,10 +314,8 @@ static void __exit iosf_mbi_exit(void)
iosf_debugfs_remove();
pci_unregister_driver(&iosf_mbi_pci_driver);
- if (mbi_pdev) {
- pci_dev_put(mbi_pdev);
- mbi_pdev = NULL;
- }
+ pci_dev_put(mbi_pdev);
+ mbi_pdev = NULL;
}
module_init(iosf_mbi_init);
next prev parent reply other threads:[~2015-07-16 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 14:45 [PATCH v2 0/5] x86/platform/iosf_mbi: fix and clean up Andy Shevchenko
2015-07-08 14:45 ` [PATCH v2 1/5] x86/platform/iosf_mbi: move to dedicated folder Andy Shevchenko
2015-07-16 15:52 ` [tip:x86/platform] x86/platform/iosf_mbi: Move " tip-bot for Andy Shevchenko
2015-07-08 14:45 ` [PATCH v2 2/5] x86/platform/iosf_mbi: check result for all calls of debugfs API Andy Shevchenko
2015-07-16 15:52 ` [tip:x86/platform] x86/platform/iosf_mbi: Check return value of debugfs_create properly tip-bot for Andy Shevchenko
2015-07-08 14:45 ` [PATCH v2 3/5] x86/platform/iosf_mbi: pci_dev_put() is NULL-proof Andy Shevchenko
2015-07-16 15:53 ` tip-bot for Andy Shevchenko [this message]
2015-07-08 14:45 ` [PATCH v2 4/5] x86/platform/iosf_mbi: group global variables Andy Shevchenko
2015-07-16 15:53 ` [tip:x86/platform] x86/platform/iosf_mbi: Source cleanup tip-bot for Andy Shevchenko
2015-07-08 14:45 ` [PATCH v2 5/5] x86/platform/iosf_mbi: append Intel Tangier ID Andy Shevchenko
2015-07-16 15:42 ` Thomas Gleixner
2015-07-16 15:53 ` [tip:x86/platform] x86/platform/iosf_mbi: Add Intel Tangier PCI id tip-bot for Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff@git.kernel.org \
--to=tipbot@zytor.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox