From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756025AbbGPPxf (ORCPT ); Thu, 16 Jul 2015 11:53:35 -0400 Received: from terminus.zytor.com ([198.137.202.10]:39116 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833AbbGPPxT (ORCPT ); Thu, 16 Jul 2015 11:53:19 -0400 Date: Thu, 16 Jul 2015 08:53:08 -0700 From: tip-bot for Andy Shevchenko Message-ID: Cc: hpa@zytor.com, andriy.shevchenko@linux.intel.com, david.e.box@linux.intel.com, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, andriy.shevchenko@linux.intel.com, david.e.box@linux.intel.com In-Reply-To: <1436366709-17683-4-git-send-email-andriy.shevchenko@linux.intel.com> References: <1436366709-17683-4-git-send-email-andriy.shevchenko@linux.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/platform] x86/platform/iosf_mbi: Remove NULL pointer checks for pci_dev_put() Git-Commit-ID: b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff Gitweb: http://git.kernel.org/tip/b93fb9f6aee0ea6fe60ed20278b9c7fea70a58ff Author: Andy Shevchenko AuthorDate: Wed, 8 Jul 2015 17:45:07 +0300 Committer: Thomas Gleixner CommitDate: Thu, 16 Jul 2015 17:48:48 +0200 x86/platform/iosf_mbi: Remove NULL pointer checks for pci_dev_put() pci_dev_put() has already a check for NULL pointer. [ tglx: Massaged changelog ] Signed-off-by: Andy Shevchenko Cc: David E . Box Link: http://lkml.kernel.org/r/1436366709-17683-4-git-send-email-andriy.shevchenko@linux.intel.com Signed-off-by: Thomas Gleixner --- arch/x86/platform/intel/iosf_mbi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c index 2362da9..0b33105 100644 --- a/arch/x86/platform/intel/iosf_mbi.c +++ b/arch/x86/platform/intel/iosf_mbi.c @@ -314,10 +314,8 @@ static void __exit iosf_mbi_exit(void) iosf_debugfs_remove(); pci_unregister_driver(&iosf_mbi_pci_driver); - if (mbi_pdev) { - pci_dev_put(mbi_pdev); - mbi_pdev = NULL; - } + pci_dev_put(mbi_pdev); + mbi_pdev = NULL; } module_init(iosf_mbi_init);