[PATCH] x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

[PATCH] x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

[Alan Cox]

From: Alan Cox <alan@linux.intel.com>

Fix the build failure reported by Randy Dunlap

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 9e71608..afe50ec 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -387,6 +387,7 @@ config X86_MRST
 	select APB_TIMER
 	select I2C
 	select SPI
+	select INTEL_SCU_IPC
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

Re: [PATCH] x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

[Randy Dunlap]

On Mon, 15 Nov 2010 17:31:19 +0000 Alan Cox wrote:

> From: Alan Cox <alan@linux.intel.com>
> 
> Fix the build failure reported by Randy Dunlap
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  arch/x86/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9e71608..afe50ec 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -387,6 +387,7 @@ config X86_MRST
>  	select APB_TIMER
>  	select I2C
>  	select SPI
> +	select INTEL_SCU_IPC
>  	---help---
>  	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
>  	  Internet Device(MID) platform. Moorestown consists of two chips:

Hi,
Additionally using this line from my patch:

+	select X86_PLATFORM_DEVICES

will avoid this warning (with your patch applied):

warning: (X86_MRST && PCI && PCI_GOANY && X86_32 && X86_EXTENDED_PLATFORM && X86_IO_APIC) selects INTEL_SCU_IPC which has unmet direct dependencies 
(X86 && X86_PLATFORM_DEVICES && X86_MRST)

which is due to the hierarchical menu structure.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

[tip:x86/platform] x86, mrst: Fix dependencies of "select INTEL_SCU_IPC"

[tip-bot for Randy Dunlap]

Commit-ID:  ad02519a0d27da4a0a50cbc696e810c94e27c28e
Gitweb:     http://git.kernel.org/tip/ad02519a0d27da4a0a50cbc696e810c94e27c28e
Author:     Randy Dunlap <randy.dunlap@oracle.com>
AuthorDate: Mon, 15 Nov 2010 10:14:06 -0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 17 Nov 2010 13:41:44 +0100

x86, mrst: Fix dependencies of "select INTEL_SCU_IPC"

commit b9fc71f47 (x86, mrst: The shutdown for MRST requires the SCU
IPC mechanism) introduced the following warning:

 warning: (X86_MRST && PCI && PCI_GOANY && X86_32 &&
 X86_EXTENDED_PLATFORM && X86_IO_APIC) selects INTEL_SCU_IPC which has
 unmet direct dependencies (X86 && X86_PLATFORM_DEVICES && X86_MRST)

which is due to the hierarchical menu structure.

Select X86_PLATFORM_DEVICES as well.

Originally-from: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <20101115101406.77e072ef.randy.dunlap@oracle.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6e877b9..655fcf5 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -400,6 +400,7 @@ config X86_MRST
 	select I2C
 	select SPI
 	select INTEL_SCU_IPC
+	select X86_PLATFORM_DEVICES
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

[tip:x86/platform] x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

[tip-bot for Alan Cox]

Commit-ID:  b9fc71f47dc060c588e5099638242fad44eeecbc
Gitweb:     http://git.kernel.org/tip/b9fc71f47dc060c588e5099638242fad44eeecbc
Author:     Alan Cox <alan@lxorguk.ukuu.org.uk>
AuthorDate: Mon, 15 Nov 2010 17:31:19 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 17 Nov 2010 13:27:44 +0100

x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

Fix the build failure reported by Randy.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
LKML-Reference: <20101115173110.6877.83958.stgit@localhost.localdomain>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e5510cf..6e877b9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -399,6 +399,7 @@ config X86_MRST
 	select APB_TIMER
 	select I2C
 	select SPI
+	select INTEL_SCU_IPC
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips: