* [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
@ 2011-02-17 15:47 Jan Beulich
2011-02-18 7:44 ` Ingo Molnar
2011-02-18 10:39 ` [tip:x86/debug] x86: Don't " tip-bot for Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2011-02-17 15:47 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
show_regs() already prints two(!) stack traces, no need for a third one.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 file changed, 1 deletion(-)
--- 2.6.38-rc5/arch/x86/kernel/apic/hw_nmi.c
+++ 2.6.38-rc5-x86-backtrace-all-no-dump_stack/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(s
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
2011-02-17 15:47 [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler() Jan Beulich
@ 2011-02-18 7:44 ` Ingo Molnar
2011-02-18 7:59 ` Jan Beulich
2011-02-18 10:39 ` [tip:x86/debug] x86: Don't " tip-bot for Jan Beulich
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2011-02-18 7:44 UTC (permalink / raw)
To: Jan Beulich; +Cc: tglx, hpa, linux-kernel
* Jan Beulich <JBeulich@novell.com> wrote:
> show_regs() already prints two(!) stack traces, [...]
That ought to get fixed as well, right?
> no need for a third one.
Agreed.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
2011-02-18 7:44 ` Ingo Molnar
@ 2011-02-18 7:59 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2011-02-18 7:59 UTC (permalink / raw)
To: Ingo Molnar; +Cc: tglx, linux-kernel, hpa
>>> On 18.02.11 at 08:44, Ingo Molnar <mingo@elte.hu> wrote:
> * Jan Beulich <JBeulich@novell.com> wrote:
>
>> show_regs() already prints two(!) stack traces, [...]
>
> That ought to get fixed as well, right?
Yes, I'm intending to send a patch for that as a follow-up.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
2011-02-17 15:47 [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler() Jan Beulich
2011-02-18 7:44 ` Ingo Molnar
@ 2011-02-18 10:39 ` tip-bot for Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Jan Beulich @ 2011-02-18 10:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jbeulich, JBeulich, tglx, mingo
Commit-ID: bb3e6251a69e67d7620373ee18e35b404964273e
Gitweb: http://git.kernel.org/tip/bb3e6251a69e67d7620373ee18e35b404964273e
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 17 Feb 2011 15:47:37 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Feb 2011 08:52:29 +0100
x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
show_regs() already prints two(!) stack traces, no need for a third one.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4D5D512902000078000326EE@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 79fd43c..c4e557a 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-18 10:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 15:47 [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler() Jan Beulich
2011-02-18 7:44 ` Ingo Molnar
2011-02-18 7:59 ` Jan Beulich
2011-02-18 10:39 ` [tip:x86/debug] x86: Don't " tip-bot for Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox