[tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

tip-bot for Jan Beulich
2011-02-18T10:40:04Z

Commit-ID: bb3e6251a69e67d7620373ee18e35b404964273e
Gitweb: http://git.kernel.org/tip/bb3e6251a69e67d7620373ee18e35b404964273e
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 17 Feb 2011 15:47:37 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Feb 2011 08:52:29 +0100

x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

show_regs() already prints two(!) stack traces, no need for a third one.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4D5D512902000078000326EE@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 79fd43c..c4e557a 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;