From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbcELKXG (ORCPT ); Thu, 12 May 2016 06:23:06 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37668 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbcELKXD (ORCPT ); Thu, 12 May 2016 06:23:03 -0400 Date: Thu, 12 May 2016 03:22:28 -0700 From: tip-bot for Chris Phlipot Message-ID: Cc: peterz@infradead.org, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, cphlipot0@gmail.com, acme@redhat.com Reply-To: cphlipot0@gmail.com, adrian.hunter@intel.com, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, tglx@linutronix.de, peterz@infradead.org In-Reply-To: <1462937209-6032-3-git-send-email-cphlipot0@gmail.com> References: <1462937209-6032-3-git-send-email-cphlipot0@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf script: Fix symbol insertion behavior in db-export Git-Commit-ID: bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a Gitweb: http://git.kernel.org/tip/bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a Author: Chris Phlipot AuthorDate: Tue, 10 May 2016 20:26:47 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 May 2016 12:24:57 -0300 perf script: Fix symbol insertion behavior in db-export Use the dso__insert_symbol function instead of symbols__insert() in order to properly update the dso symbol cache. If the cache is not updated, then duplicate symbols can be unintentionally created, inserted, and exported. This change prevents duplicate symbols from being exported due to dso__find_symbol() using a stale symbol cache. Signed-off-by: Chris Phlipot Cc: Adrian Hunter Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1462937209-6032-3-git-send-email-cphlipot0@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/db-export.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c index f8e3057..2ef1f69 100644 --- a/tools/perf/util/db-export.c +++ b/tools/perf/util/db-export.c @@ -260,8 +260,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al, if (!al->sym) { al->sym = symbol__new(al->addr, 0, 0, "unknown"); if (al->sym) - symbols__insert(&dso->symbols[al->map->type], - al->sym); + dso__insert_symbol(dso, al->map->type, al->sym); } if (al->sym) {