From: tip-bot for Wang Nan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, jolsa@redhat.com,
mingo@kernel.org, mhiramat@kernel.org, tglx@linutronix.de,
wangnan0@huawei.com, namhyung@kernel.org, hekuang@huawei.com,
lizefan@huawei.com, adrian.hunter@intel.com, acme@redhat.com
Subject: [tip:perf/core] perf record: Generate tracking events for process forked by perf
Date: Sun, 1 May 2016 00:41:05 -0700 [thread overview]
Message-ID: <tip-be7b0c9e376e93a00b6c8631e2721e9dc7c6a1fa@git.kernel.org> (raw)
In-Reply-To: <1461178794-40467-8-git-send-email-wangnan0@huawei.com>
Commit-ID: be7b0c9e376e93a00b6c8631e2721e9dc7c6a1fa
Gitweb: http://git.kernel.org/tip/be7b0c9e376e93a00b6c8631e2721e9dc7c6a1fa
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Wed, 20 Apr 2016 18:59:54 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 28 Apr 2016 09:58:59 -0300
perf record: Generate tracking events for process forked by perf
With 'perf record --switch-output' without -a, record__synthesize() in
record__switch_output() won't generate tracking events because there's
no thread_map in evlist. Which causes newly created perf.data doesn't
contain map and comm information.
This patch creates a fake thread_map and directly call
perf_event__synthesize_thread_map() for those events.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1461178794-40467-8-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 31 ++++++++++++++++++++++++++++++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 178b49e..f3679c4 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -500,6 +500,23 @@ record__finish_output(struct record *rec)
return;
}
+static int record__synthesize_workload(struct record *rec)
+{
+ struct {
+ struct thread_map map;
+ struct thread_map_data map_data;
+ } thread_map;
+
+ thread_map.map.nr = 1;
+ thread_map.map.map[0].pid = rec->evlist->workload.pid;
+ thread_map.map.map[0].comm = NULL;
+ return perf_event__synthesize_thread_map(&rec->tool, &thread_map.map,
+ process_synthesized_event,
+ &rec->session->machines.host,
+ rec->opts.sample_address,
+ rec->opts.proc_map_timeout);
+}
+
static int record__synthesize(struct record *rec);
static int
@@ -532,9 +549,21 @@ record__switch_output(struct record *rec, bool at_exit)
file->path, timestamp);
/* Output tracking events */
- if (!at_exit)
+ if (!at_exit) {
record__synthesize(rec);
+ /*
+ * In 'perf record --switch-output' without -a,
+ * record__synthesize() in record__switch_output() won't
+ * generate tracking events because there's no thread_map
+ * in evlist. Which causes newly created perf.data doesn't
+ * contain map and comm information.
+ * Create a fake thread_map and directly call
+ * perf_event__synthesize_thread_map() for those events.
+ */
+ if (target__none(&rec->opts.target))
+ record__synthesize_workload(rec);
+ }
return fd;
}
next prev parent reply other threads:[~2016-05-01 7:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 18:59 [PATCH v6 0/7] perf tools: Use SIGUSR2 control data dumpping Wang Nan
2016-04-20 18:59 ` [PATCH v6 1/7] perf tools: Introduce trigger class Wang Nan
2016-05-01 7:39 ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 2/7] perf tools: Derive trigger class from auxtrace_snapshot Wang Nan
2016-04-26 13:54 ` Arnaldo Carvalho de Melo
2016-04-27 9:10 ` Adrian Hunter
2016-05-01 7:39 ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 3/7] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-04-27 21:32 ` Arnaldo Carvalho de Melo
2016-04-29 4:56 ` Wangnan (F)
2016-05-01 7:39 ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 4/7] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-05-01 7:40 ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 5/7] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-05-01 7:40 ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 6/7] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-04-20 18:59 ` [PATCH v6 7/7] perf record: Generate tracking events for process forked by perf Wang Nan
2016-05-01 7:41 ` tip-bot for Wang Nan [this message]
2016-04-22 10:30 ` [PATCH v6 0/7] perf tools: Use SIGUSR2 control data dumpping Jiri Olsa
2016-04-27 21:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-be7b0c9e376e93a00b6c8631e2721e9dc7c6a1fa@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).