Re: [PATCH 28/52] perf script: Allow callchains if any event samples them

David Ahern
2014-07-25T15:32:22Z

On 7/25/14, 7:27 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 22, 2014 at 04:17:37PM +0300, Adrian Hunter escreveu:
>> perf script was not displaying callchains if any selected
>> event did not have PERF_SAMPLE_CALLCHAIN. Change this to
>> disable callchains only if all selected events do not have
>> PERF_SAMPLE_CALLCHAIN.
>
> I wonder if some other tool gets this wrong as well, report maybe?
>

perf only handles 1 sample_type so if callchains are enabled for 1 event
they are enabled for all.

Perhaps Adrian's patch set changes that -- prior patch sets attempted
to. I have not had time to go through the list.

David