* [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting
@ 2009-12-28 9:02 Pekka Enberg
2009-12-28 9:28 ` Ingo Molnar
2009-12-28 10:08 ` [tip:x86/urgent] x86, kmemcheck: " tip-bot for Pekka Enberg
0 siblings, 2 replies; 4+ messages in thread
From: Pekka Enberg @ 2009-12-28 9:02 UTC (permalink / raw)
To: vegard.nossum; +Cc: akpm, x86, mingo, linux-kernel
From: Pekka Enberg <penberg@cs.helsinki.fi>
As suggested by Vegard Nossum, use KERN_WARNING for error reporting to make
sure kmemcheck reports end up in syslog.
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
Vegard, how do you want to merge this? Andrew? Ingo? I can also pick it
up in my tree if you ACK it.
arch/x86/mm/kmemcheck/error.c | 19 +++++++++----------
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/arch/x86/mm/kmemcheck/error.c b/arch/x86/mm/kmemcheck/error.c
index 4901d0d..af3b6c8 100644
--- a/arch/x86/mm/kmemcheck/error.c
+++ b/arch/x86/mm/kmemcheck/error.c
@@ -106,26 +106,25 @@ void kmemcheck_error_recall(void)
switch (e->type) {
case KMEMCHECK_ERROR_INVALID_ACCESS:
- printk(KERN_ERR "WARNING: kmemcheck: Caught %d-bit read "
- "from %s memory (%p)\n",
+ printk(KERN_WARNING "WARNING: kmemcheck: Caught %d-bit read from %s memory (%p)\n",
8 * e->size, e->state < ARRAY_SIZE(desc) ?
desc[e->state] : "(invalid shadow state)",
(void *) e->address);
- printk(KERN_INFO);
+ printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i)
- printk("%02x", e->memory_copy[i]);
- printk("\n");
+ printk(KERN_CONT "%02x", e->memory_copy[i]);
+ printk(KERN_CONT "\n");
- printk(KERN_INFO);
+ printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i) {
if (e->shadow_copy[i] < ARRAY_SIZE(short_desc))
- printk(" %c", short_desc[e->shadow_copy[i]]);
+ printk(KERN_CONT " %c", short_desc[e->shadow_copy[i]]);
else
- printk(" ?");
+ printk(KERN_CONT " ?");
}
- printk("\n");
- printk(KERN_INFO "%*c\n", 2 + 2
+ printk(KERN_CONT "\n");
+ printk(KERN_WARNING "%*c\n", 2 + 2
* (int) (e->address & (SHADOW_COPY_SIZE - 1)), '^');
break;
case KMEMCHECK_ERROR_BUG:
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting
2009-12-28 9:02 [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting Pekka Enberg
@ 2009-12-28 9:28 ` Ingo Molnar
2009-12-28 10:15 ` Pekka Enberg
2009-12-28 10:08 ` [tip:x86/urgent] x86, kmemcheck: " tip-bot for Pekka Enberg
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2009-12-28 9:28 UTC (permalink / raw)
To: Pekka Enberg; +Cc: vegard.nossum, akpm, x86, linux-kernel
* Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> As suggested by Vegard Nossum, use KERN_WARNING for error reporting to make
> sure kmemcheck reports end up in syslog.
>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> Vegard, how do you want to merge this? Andrew? Ingo? I can also pick it
> up in my tree if you ACK it.
Can apply it to x86/urgent, next to your other printk-loglevel-fixing patch.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting
2009-12-28 9:28 ` Ingo Molnar
@ 2009-12-28 10:15 ` Pekka Enberg
0 siblings, 0 replies; 4+ messages in thread
From: Pekka Enberg @ 2009-12-28 10:15 UTC (permalink / raw)
To: Ingo Molnar; +Cc: vegard.nossum, akpm, x86, linux-kernel
On Mon, 2009-12-28 at 10:28 +0100, Ingo Molnar wrote:
> * Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
> > From: Pekka Enberg <penberg@cs.helsinki.fi>
> >
> > As suggested by Vegard Nossum, use KERN_WARNING for error reporting to make
> > sure kmemcheck reports end up in syslog.
> >
> > Cc: Vegard Nossum <vegard.nossum@gmail.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> > ---
> > Vegard, how do you want to merge this? Andrew? Ingo? I can also pick it
> > up in my tree if you ACK it.
>
> Can apply it to x86/urgent, next to your other printk-loglevel-fixing patch.
OK, thanks Ingo!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86, kmemcheck: Use KERN_WARNING for error reporting
2009-12-28 9:02 [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting Pekka Enberg
2009-12-28 9:28 ` Ingo Molnar
@ 2009-12-28 10:08 ` tip-bot for Pekka Enberg
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Pekka Enberg @ 2009-12-28 10:08 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, akpm, penberg, vegard.nossum, tglx,
mingo
Commit-ID: c0ca9da442df82b67095f230f24762042f9f3b7d
Gitweb: http://git.kernel.org/tip/c0ca9da442df82b67095f230f24762042f9f3b7d
Author: Pekka Enberg <penberg@cs.helsinki.fi>
AuthorDate: Mon, 28 Dec 2009 11:02:15 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 28 Dec 2009 10:28:35 +0100
x86, kmemcheck: Use KERN_WARNING for error reporting
As suggested by Vegard Nossum, use KERN_WARNING for error
reporting to make sure kmemcheck reports end up in syslog.
Suggested-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1261990935.4641.7.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/kmemcheck/error.c | 19 +++++++++----------
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/arch/x86/mm/kmemcheck/error.c b/arch/x86/mm/kmemcheck/error.c
index 4901d0d..af3b6c8 100644
--- a/arch/x86/mm/kmemcheck/error.c
+++ b/arch/x86/mm/kmemcheck/error.c
@@ -106,26 +106,25 @@ void kmemcheck_error_recall(void)
switch (e->type) {
case KMEMCHECK_ERROR_INVALID_ACCESS:
- printk(KERN_ERR "WARNING: kmemcheck: Caught %d-bit read "
- "from %s memory (%p)\n",
+ printk(KERN_WARNING "WARNING: kmemcheck: Caught %d-bit read from %s memory (%p)\n",
8 * e->size, e->state < ARRAY_SIZE(desc) ?
desc[e->state] : "(invalid shadow state)",
(void *) e->address);
- printk(KERN_INFO);
+ printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i)
- printk("%02x", e->memory_copy[i]);
- printk("\n");
+ printk(KERN_CONT "%02x", e->memory_copy[i]);
+ printk(KERN_CONT "\n");
- printk(KERN_INFO);
+ printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i) {
if (e->shadow_copy[i] < ARRAY_SIZE(short_desc))
- printk(" %c", short_desc[e->shadow_copy[i]]);
+ printk(KERN_CONT " %c", short_desc[e->shadow_copy[i]]);
else
- printk(" ?");
+ printk(KERN_CONT " ?");
}
- printk("\n");
- printk(KERN_INFO "%*c\n", 2 + 2
+ printk(KERN_CONT "\n");
+ printk(KERN_WARNING "%*c\n", 2 + 2
* (int) (e->address & (SHADOW_COPY_SIZE - 1)), '^');
break;
case KMEMCHECK_ERROR_BUG:
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-28 10:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-28 9:02 [PATCH] x86,kmemcheck: Use KERN_WARNING for error reporting Pekka Enberg
2009-12-28 9:28 ` Ingo Molnar
2009-12-28 10:15 ` Pekka Enberg
2009-12-28 10:08 ` [tip:x86/urgent] x86, kmemcheck: " tip-bot for Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox