From: tip-bot for David Ahern <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, dsahern@gmail.com, tglx@linutronix.de
Subject: [tip:perf/core] perf session: Remove unused perf_session__remove_thread method
Date: Thu, 21 Mar 2013 04:28:57 -0700 [thread overview]
Message-ID: <tip-c1ad050caad5fbff13fd2f54f49e184bd71de90d@git.kernel.org> (raw)
In-Reply-To: <1363151248-16674-4-git-send-email-dsahern@gmail.com>
Commit-ID: c1ad050caad5fbff13fd2f54f49e184bd71de90d
Gitweb: http://git.kernel.org/tip/c1ad050caad5fbff13fd2f54f49e184bd71de90d
Author: David Ahern <dsahern@gmail.com>
AuthorDate: Tue, 12 Mar 2013 23:07:27 -0600
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Mar 2013 13:06:08 -0300
perf session: Remove unused perf_session__remove_thread method
Should have been removed on this changeset, that removed the last user
of it:
743eb868657bdb1b26c7b24077ca21c67c82c777
perf tools: Resolve machine earlier and pass it to perf_event_ops
Signed-off-by: David Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1363151248-16674-4-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 12 ------------
tools/perf/util/session.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index bd85280b..ab265c2 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1365,18 +1365,6 @@ size_t perf_session__fprintf(struct perf_session *session, FILE *fp)
return machine__fprintf(&session->machines.host, fp);
}
-void perf_session__remove_thread(struct perf_session *session,
- struct thread *th)
-{
- /*
- * FIXME: This one makes no sense, we need to remove the thread from
- * the machine it belongs to, perf_session can have many machines, so
- * doing it always on ->machines.host is wrong. Fix when auditing all
- * the 'perf kvm' code.
- */
- machine__remove_thread(&session->machines.host, th);
-}
-
struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session,
unsigned int type)
{
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index b5c0847..6b51d47 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -72,7 +72,6 @@ void perf_event__attr_swap(struct perf_event_attr *attr);
int perf_session__create_kernel_maps(struct perf_session *self);
void perf_session__set_id_hdr_size(struct perf_session *session);
-void perf_session__remove_thread(struct perf_session *self, struct thread *th);
static inline
struct machine *perf_session__find_machine(struct perf_session *self, pid_t pid)
next prev parent reply other threads:[~2013-03-21 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 5:07 [PATCH 0/4] perf: remove unused functions David Ahern
2013-03-13 5:07 ` [PATCH 1/4] perf: remove unused print_event function David Ahern
2013-03-13 5:07 ` [PATCH 2/4] perf: remove unused print_trace_event function David Ahern
2013-03-21 11:27 ` [tip:perf/core] perf tools: Remove unused tracing functions tip-bot for David Ahern
2013-03-13 5:07 ` [PATCH 3/4] perf: remove unused perf_session__remove_thread David Ahern
2013-03-21 11:28 ` tip-bot for David Ahern [this message]
2013-03-13 5:07 ` [PATCH 4/4] perf: move machine__remove_thread and make static David Ahern
2013-03-21 11:30 ` [tip:perf/core] perf machine: Move " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c1ad050caad5fbff13fd2f54f49e184bd71de90d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).