From: tip-bot for Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@redhat.com, guijianfeng@cn.fujitsu.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:perf/urgent] perf tools: Fix find tids routine by excluding "." and ".."
Date: Sat, 3 Jul 2010 13:57:44 GMT [thread overview]
Message-ID: <tip-c214909b36efec632432acdcbfacdd46a6e11370@git.kernel.org> (raw)
In-Reply-To: <4C185F68.1020505@cn.fujitsu.com>
Commit-ID: c214909b36efec632432acdcbfacdd46a6e11370
Gitweb: http://git.kernel.org/tip/c214909b36efec632432acdcbfacdd46a6e11370
Author: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
AuthorDate: Wed, 16 Jun 2010 13:21:44 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 1 Jul 2010 14:02:38 -0300
perf tools: Fix find tids routine by excluding "." and ".."
Introduce a filter function to skip "." and ".." directories when calculating
tid number, otherwise tid 0 will be included in the all_tid result array.
Cc: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <4C185F68.1020505@cn.fujitsu.com>
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/thread.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 1f7ecd4..9a448b4 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -7,6 +7,15 @@
#include "util.h"
#include "debug.h"
+/* Skip "." and ".." directories */
+static int filter(const struct dirent *dir)
+{
+ if (dir->d_name[0] == '.')
+ return 0;
+ else
+ return 1;
+}
+
int find_all_tid(int pid, pid_t ** all_tid)
{
char name[256];
@@ -16,7 +25,7 @@ int find_all_tid(int pid, pid_t ** all_tid)
int i;
sprintf(name, "/proc/%d/task", pid);
- items = scandir(name, &namelist, NULL, NULL);
+ items = scandir(name, &namelist, filter, NULL);
if (items <= 0)
return -ENOENT;
*all_tid = malloc(sizeof(pid_t) * items);
prev parent reply other threads:[~2010-07-03 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 8:58 [PATCH] perf: excluding "." and ".." directories when calculating tids Gui Jianfeng
2010-06-15 9:33 ` Gui Jianfeng
2010-06-16 5:21 ` Gui Jianfeng
2010-06-16 16:35 ` Adam Schrotenboer
2010-06-17 3:11 ` Gui Jianfeng
2010-06-18 14:40 ` Arnaldo Carvalho de Melo
2010-07-03 13:57 ` tip-bot for Gui Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c214909b36efec632432acdcbfacdd46a6e11370@git.kernel.org \
--to=guijianfeng@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox