From: tip-bot for Konstantin Khlebnikov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: efault@gmx.de, david.vrabel@citrix.com,
linux-kernel@vger.kernel.org, hpa@zytor.com,
boris.ostrovsky@oracle.com, paulus@samba.org, agraf@suse.de,
mingo@kernel.org, tglx@linutronix.de,
torvalds@linux-foundation.org, khlebnikov@yandex-team.ru,
peterz@infradead.org
Subject: [tip:sched/core] sched/preempt, powerpc, kvm: Use need_resched() instead of should_resched()
Date: Mon, 3 Aug 2015 10:08:00 -0700 [thread overview]
Message-ID: <tip-c56dadf39761a6157239cac39e3988998c994f98@git.kernel.org> (raw)
In-Reply-To: <20150715095203.12246.72922.stgit@buzz>
Commit-ID: c56dadf39761a6157239cac39e3988998c994f98
Gitweb: http://git.kernel.org/tip/c56dadf39761a6157239cac39e3988998c994f98
Author: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
AuthorDate: Wed, 15 Jul 2015 12:52:03 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 3 Aug 2015 12:21:24 +0200
sched/preempt, powerpc, kvm: Use need_resched() instead of should_resched()
Function should_resched() is equal to (!preempt_count() && need_resched()).
In preemptive kernel preempt_count here is non-zero because of vc->lock.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Graf <agraf@suse.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150715095203.12246.72922.stgit@buzz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/powerpc/kvm/book3s_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 68d067a..a9f753f 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -2178,7 +2178,7 @@ static int kvmppc_run_vcpu(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
vc->runner = vcpu;
if (n_ceded == vc->n_runnable) {
kvmppc_vcore_blocked(vc);
- } else if (should_resched()) {
+ } else if (need_resched()) {
vc->vcore_state = VCORE_PREEMPT;
/* Let something else run */
cond_resched_lock(&vc->lock);
next prev parent reply other threads:[~2015-08-03 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 9:52 [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched() Konstantin Khlebnikov
2015-07-15 9:52 ` [PATCH v2 2/3] KVM: PPC: Book3S HV: Use " Konstantin Khlebnikov
2015-08-03 17:08 ` tip-bot for Konstantin Khlebnikov [this message]
2015-07-15 9:52 ` [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and cond_resched_softirq() Konstantin Khlebnikov
2015-07-15 12:16 ` Eric Dumazet
2015-07-15 12:52 ` Konstantin Khlebnikov
2015-07-15 13:35 ` Peter Zijlstra
2015-08-03 17:08 ` [tip:sched/core] sched/preempt: Fix " tip-bot for Konstantin Khlebnikov
2015-07-20 13:41 ` [Xen-devel] [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched() David Vrabel
2015-08-03 17:07 ` [tip:sched/core] sched/preempt, xen: Use " tip-bot for Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c56dadf39761a6157239cac39e3988998c994f98@git.kernel.org \
--to=tipbot@zytor.com \
--cc=agraf@suse.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).