public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ix86: in kernel context print control and debug registers too
@ 2012-03-08  9:23 Jan Beulich
  2012-03-08 10:18 ` [tip:x86/asm] x86/32: Print control and debug registers for kerenel context tip-bot for Jan Beulich
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-03-08  9:23 UTC (permalink / raw)
  To: mingo, tglx, hpa; +Cc: linux-kernel

While for a user mode register dump it may be reasonable to skip those
(albeit x86-64 doesn't do so), for kernel mode dumps these should be
printed to make sure all information possibly necessary for analysis is
available.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

---
 arch/x86/kernel/dumpstack_32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 3.3-rc6/arch/x86/kernel/dumpstack_32.c
+++ 3.3-rc6-ix86-kernel-show-all-regs/arch/x86/kernel/dumpstack_32.c
@@ -87,7 +87,7 @@ void show_registers(struct pt_regs *regs
 	int i;
 
 	print_modules();
-	__show_regs(regs, 0);
+	__show_regs(regs, !user_mode_vm(regs));
 
 	printk(KERN_EMERG "Process %.*s (pid: %d, ti=%p task=%p task.ti=%p)\n",
 		TASK_COMM_LEN, current->comm, task_pid_nr(current),




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/asm] x86/32: Print control and debug registers for kerenel context
  2012-03-08  9:23 [PATCH] ix86: in kernel context print control and debug registers too Jan Beulich
@ 2012-03-08 10:18 ` tip-bot for Jan Beulich
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jan Beulich @ 2012-03-08 10:18 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, jbeulich, JBeulich, tglx, mingo

Commit-ID:  c7e23289a6aa95048a78b252b462f24ca6cf7f96
Gitweb:     http://git.kernel.org/tip/c7e23289a6aa95048a78b252b462f24ca6cf7f96
Author:     Jan Beulich <JBeulich@suse.com>
AuthorDate: Thu, 8 Mar 2012 09:23:14 +0000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 8 Mar 2012 10:57:35 +0100

x86/32: Print control and debug registers for kerenel context

While for a user mode register dump it may be reasonable to skip
those (albeit x86-64 doesn't do so), for kernel mode dumps these
should be printed to make sure all information possibly
necessary for analysis is available.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Link: http://lkml.kernel.org/r/4F58889202000078000770E7@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/dumpstack_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c
index c99f9ed..88ec912 100644
--- a/arch/x86/kernel/dumpstack_32.c
+++ b/arch/x86/kernel/dumpstack_32.c
@@ -87,7 +87,7 @@ void show_registers(struct pt_regs *regs)
 	int i;
 
 	print_modules();
-	__show_regs(regs, 0);
+	__show_regs(regs, !user_mode_vm(regs));
 
 	printk(KERN_EMERG "Process %.*s (pid: %d, ti=%p task=%p task.ti=%p)\n",
 		TASK_COMM_LEN, current->comm, task_pid_nr(current),

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-08 10:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08  9:23 [PATCH] ix86: in kernel context print control and debug registers too Jan Beulich
2012-03-08 10:18 ` [tip:x86/asm] x86/32: Print control and debug registers for kerenel context tip-bot for Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox