From: tip-bot for Alexander Gordeev <agordeev@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, agordeev@redhat.com, hpa@zytor.com,
mingo@kernel.org, yinghai@kernel.org, suresh.b.siddha@intel.com,
tglx@linutronix.de
Subject: [tip:x86/apic] x86/x2apic/cluster: Vector_allocation_domain() should return a value
Date: Thu, 14 Jun 2012 07:45:38 -0700 [thread overview]
Message-ID: <tip-cac4afbc3da58d9e5701b34bd4c1f11ea13328d4@git.kernel.org> (raw)
In-Reply-To: <20120614103933.GJ3383@dhcp-26-207.brq.redhat.com>
Commit-ID: cac4afbc3da58d9e5701b34bd4c1f11ea13328d4
Gitweb: http://git.kernel.org/tip/cac4afbc3da58d9e5701b34bd4c1f11ea13328d4
Author: Alexander Gordeev <agordeev@redhat.com>
AuthorDate: Thu, 14 Jun 2012 12:39:34 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 14 Jun 2012 12:53:12 +0200
x86/x2apic/cluster: Vector_allocation_domain() should return a value
Since commit 8637e38 ("x86/apic: Avoid useless scanning thru a
cpumask in assign_irq_vector()") vector_allocation_domain()
operation indicates if a cpumask is dynamic or static. This
update fixes the oversight and makes the operation to return a
value.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Link: http://lkml.kernel.org/r/20120614103933.GJ3383@dhcp-26-207.brq.redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/apic/x2apic_cluster.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 23a46cf..1885a73 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -228,10 +228,11 @@ static int x2apic_cluster_probe(void)
/*
* Each x2apic cluster is an allocation domain.
*/
-static void cluster_vector_allocation_domain(int cpu, struct cpumask *retmask)
+static bool cluster_vector_allocation_domain(int cpu, struct cpumask *retmask)
{
cpumask_clear(retmask);
cpumask_copy(retmask, per_cpu(cpus_in_cluster, cpu));
+ return true;
}
static struct apic apic_x2apic_cluster = {
next prev parent reply other threads:[~2012-06-14 14:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1339657103.git.agordeev@redhat.com>
2012-06-14 7:49 ` [PATCH 1/6] x86/x2apic/cluster: vector_allocation_domain() should return a value Alexander Gordeev
2012-06-14 9:59 ` Ingo Molnar
2012-06-14 10:39 ` Alexander Gordeev
2012-06-14 14:45 ` tip-bot for Alexander Gordeev [this message]
2012-06-14 7:49 ` [PATCH 2/6] x86/apic: Eliminate cpu_mask_to_apicid() operation Alexander Gordeev
2012-06-14 14:46 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-14 7:49 ` [PATCH 3/6] x86/apic: Fix ugly casting and branching in cpu_mask_to_apicid_and() Alexander Gordeev
2012-06-14 13:00 ` Joe Perches
2012-06-14 14:47 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-14 7:50 ` [PATCH 4/6] x86/apic/es7000+summit: Fix compile warning in cpu_mask_to_apicid() Alexander Gordeev
2012-06-14 14:48 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-14 7:50 ` [PATCH 5/6] x86/apic/es7000+summit: Always make valid apicid from a cpumask Alexander Gordeev
2012-06-14 14:49 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-14 7:50 ` [PATCH 6/6] x86/apic/es7000: Make apicid of a cluster (not CPU) " Alexander Gordeev
2012-06-14 14:50 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-cac4afbc3da58d9e5701b34bd4c1f11ea13328d4@git.kernel.org \
--to=agordeev@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox