linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Avi Kivity <avi@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
	tracek@redhat.com, hpa@zytor.com, mingo@kernel.org,
	anthony@codemonkey.ws, alan@lxorguk.ukuu.org.uk,
	mtosatti@redhat.com, tglx@linutronix.de, mjt@tls.msk.ru,
	hpa@linux.intel.com, avi@redhat.com, borislav.petkov@amd.com
Subject: [tip:x86/urgent] x86/alternatives: Fix p6 nops on non-modular kernels
Date: Wed, 22 Aug 2012 03:21:52 -0700	[thread overview]
Message-ID: <tip-cb09cad44f07044d9810f18f6f9a6a6f3771f979@git.kernel.org> (raw)
In-Reply-To: <5034AE84.90708@redhat.com>

Commit-ID:  cb09cad44f07044d9810f18f6f9a6a6f3771f979
Gitweb:     http://git.kernel.org/tip/cb09cad44f07044d9810f18f6f9a6a6f3771f979
Author:     Avi Kivity <avi@redhat.com>
AuthorDate: Wed, 22 Aug 2012 13:03:48 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 22 Aug 2012 12:09:49 +0200

x86/alternatives: Fix p6 nops on non-modular kernels

Probably a leftover from the early days of self-patching, p6nops
are marked __initconst_or_module, which causes them to be
discarded in a non-modular kernel.  If something later triggers
patching, it will overwrite kernel code with garbage.

Reported-by: Tomas Racek <tracek@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: Borislav Petkov <borislav.petkov@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org
Cc: Anthony Liguori <anthony@codemonkey.ws>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/5034AE84.90708@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/alternative.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index afb7ff7..ced4534 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -165,7 +165,7 @@ static const unsigned char * const k7_nops[ASM_NOP_MAX+2] =
 #endif
 
 #ifdef P6_NOP1
-static const unsigned char  __initconst_or_module p6nops[] =
+static const unsigned char p6nops[] =
 {
 	P6_NOP1,
 	P6_NOP2,

  reply	other threads:[~2012-08-22 10:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1104118228.1760802.1345121009530.JavaMail.root@redhat.com>
2012-08-16 13:35 ` x86, nops settings result in kernel crash Tomas Racek
2012-08-16 13:48   ` Borislav Petkov
2012-08-16 18:45     ` Tomas Racek
2012-08-16 18:53       ` Alan Cox
2012-08-16 21:30         ` H. Peter Anvin
2012-08-17  7:42           ` Tomas Racek
2012-08-16 21:51         ` [Qemu-devel] " Anthony Liguori
2012-08-17  7:43           ` Tomas Racek
2012-08-17  8:09             ` Borislav Petkov
2012-08-20 17:13               ` Tomas Racek
2012-08-21  7:22                 ` Michael Tokarev
2012-08-21  9:28                   ` Tomas Racek
2012-08-22  9:54                     ` Avi Kivity
2012-08-22 10:03                       ` [PATCH] x86, alternative: fix p6 nops on non-modular kernels Avi Kivity
2012-08-22 10:21                         ` tip-bot for Avi Kivity [this message]
2012-08-22 10:33                         ` Tomas Racek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cb09cad44f07044d9810f18f6f9a6a6f3771f979@git.kernel.org \
    --to=avi@redhat.com \
    --cc=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=anthony@codemonkey.ws \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=mtosatti@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tracek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).