From: tip-bot for Paul Gortmaker <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
fei.yang@intel.com, david.a.cohen@linux.intel.com,
sathyanarayanan.kuppuswamy@linux.intel.com, tglx@linutronix.de,
hpa@linux.intel.com, fengguang.wu@intel.com,
paul.gortmaker@windriver.com
Subject: [tip:x86/intel-mid] x86: Don' t introduce more __cpuinit users in intel_mid_weak_decls.h
Date: Wed, 22 Jan 2014 14:24:38 -0800 [thread overview]
Message-ID: <tip-cbe48bc8cd279ad519624c331dad5a291891ef05@git.kernel.org> (raw)
In-Reply-To: <1390412055-19341-1-git-send-email-paul.gortmaker@windriver.com>
Commit-ID: cbe48bc8cd279ad519624c331dad5a291891ef05
Gitweb: http://git.kernel.org/tip/cbe48bc8cd279ad519624c331dad5a291891ef05
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Wed, 22 Jan 2014 12:34:15 -0500
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 22 Jan 2014 14:21:14 -0800
x86: Don't introduce more __cpuinit users in intel_mid_weak_decls.h
Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid:
Add Clovertrail platform support") added new instances of __cpuinit
usage. We removed this a couple versions ago; we now want to remove
the compat no-op stubs. Introducing new users is not what we want to
see at this point in time, as it will break once the stubs are gone.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Fei Yang <fei.yang@intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
Link: http://lkml.kernel.org/r/1390412055-19341-1-git-send-email-paul.gortmaker@windriver.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/platform/intel-mid/intel_mid_weak_decls.h | 4 ++--
arch/x86/platform/intel-mid/mfld.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
index a537ffc..41fe17d 100644
--- a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
+++ b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
@@ -14,6 +14,6 @@
/* For every CPU addition a new get_<cpuname>_ops interface needs
* to be added.
*/
-extern void * __cpuinit get_penwell_ops(void) __attribute__((weak));
-extern void * __cpuinit get_cloverview_ops(void) __attribute__((weak));
+extern void *get_penwell_ops(void) __attribute__((weak));
+extern void *get_cloverview_ops(void) __attribute__((weak));
extern void * __init get_tangier_ops(void) __attribute__((weak));
diff --git a/arch/x86/platform/intel-mid/mfld.c b/arch/x86/platform/intel-mid/mfld.c
index 4f7884e..88b06fc 100644
--- a/arch/x86/platform/intel-mid/mfld.c
+++ b/arch/x86/platform/intel-mid/mfld.c
@@ -64,12 +64,12 @@ static void __init penwell_arch_setup()
pm_power_off = mfld_power_off;
}
-void * __cpuinit get_penwell_ops()
+void *get_penwell_ops()
{
return &penwell_ops;
}
-void * __cpuinit get_cloverview_ops()
+void *get_cloverview_ops()
{
return &penwell_ops;
}
prev parent reply other threads:[~2014-01-22 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52dff2dd.pH9hExjpyBbWvw0a%fengguang.wu@intel.com>
2014-01-22 16:59 ` [PATCH] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h Paul Gortmaker
2014-01-22 17:04 ` Paul Gortmaker
2014-01-22 17:34 ` [PATCH v2] " Paul Gortmaker
2014-01-22 18:11 ` David Cohen
2014-01-22 21:50 ` David Cohen
2014-01-22 21:58 ` Paul Gortmaker
2014-01-22 22:13 ` David Cohen
2014-01-22 22:03 ` H. Peter Anvin
2014-01-22 22:10 ` Paul Gortmaker
2014-01-22 22:19 ` David Cohen
2014-01-22 22:22 ` [PATCH] x86: intel-mid: add missing 'void' to functions without arguments David Cohen
2014-01-22 22:33 ` [tip:x86/intel-mid] x86, intel-mid: Add " tip-bot for David Cohen
2014-01-22 22:24 ` tip-bot for Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-cbe48bc8cd279ad519624c331dad5a291891ef05@git.kernel.org \
--to=tipbot@zytor.com \
--cc=david.a.cohen@linux.intel.com \
--cc=fei.yang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox