Re: [PATCH 10/20] hpfs: replace BKL with a global mutex

Andi Kleen
2011-01-26T16:52:18Z

On Wed, Jan 26, 2011 at 01:50:42PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 January 2011, Andi Kleen wrote:
> > I don't think that's a very good idea, there's danger
> > of holding it over IO and that would be really bad (as in like MINIX[1])
> >
> > It would be better to do it the i810 way and check for the number of
> > CPUs at module init time and refuse to run if it's > 1
>
> I don't see much value of one evil over the other, but why not. The code
> is going away anyway unless someone cleans it up further.

I think it's fine because systems running OS/2 likely only have
one CPU. This way these guys (if they exist) won't see any regression.

-Andi
--
Andi Kleen
Intel Open Source Technology Center