public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Suresh Siddha <suresh.b.siddha@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vatsa@linux.vnet.ibm.com,
	hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
	suresh.b.siddha@intel.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/core] sched, nohz: Set the NOHZ_BALANCE_KICK flag for idle load balancer
Date: Tue, 6 Dec 2011 12:24:55 -0800	[thread overview]
Message-ID: <tip-cd490c5b285544dc1319cf79c2ca0528a6447f61@git.kernel.org> (raw)
In-Reply-To: <1323199594.1984.18.camel@sbsiddha-desk.sc.intel.com>

Commit-ID:  cd490c5b285544dc1319cf79c2ca0528a6447f61
Gitweb:     http://git.kernel.org/tip/cd490c5b285544dc1319cf79c2ca0528a6447f61
Author:     Suresh Siddha <suresh.b.siddha@intel.com>
AuthorDate: Tue, 6 Dec 2011 11:26:34 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 6 Dec 2011 20:51:29 +0100

sched, nohz: Set the NOHZ_BALANCE_KICK flag for idle load balancer

Intention is to set the NOHZ_BALANCE_KICK flag for the 'ilb_cpu'. Not
for the 'cpu' which is the local cpu. Fix the typo.

Reported-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1323199594.1984.18.camel@sbsiddha-desk.sc.intel.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched/fair.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8be45ed..6482136 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4853,7 +4853,7 @@ static void nohz_balancer_kick(int cpu)
 	if (ilb_cpu >= nr_cpu_ids)
 		return;
 
-	if (test_and_set_bit(NOHZ_BALANCE_KICK, nohz_flags(cpu)))
+	if (test_and_set_bit(NOHZ_BALANCE_KICK, nohz_flags(ilb_cpu)))
 		return;
 	/*
 	 * Use smp_send_reschedule() instead of resched_cpu().

  parent reply	other threads:[~2011-12-06 20:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02  1:07 [patch v3 0/6] nohz idle load balancing patches Suresh Siddha
2011-12-02  1:07 ` [patch v3 1/6] sched, nohz: introduce nohz_flags in the struct rq Suresh Siddha
2011-12-06  9:53   ` [tip:sched/core] sched, nohz: Introduce nohz_flags in 'struct rq' tip-bot for Suresh Siddha
2011-12-06 12:14   ` [patch v3 1/6] sched, nohz: introduce nohz_flags in the struct rq Srivatsa Vaddagiri
2011-12-06 19:26     ` Suresh Siddha
2011-12-06 19:39       ` Peter Zijlstra
2011-12-06 20:24       ` tip-bot for Suresh Siddha [this message]
2011-12-02  1:07 ` [patch v3 2/6] sched, nohz: track nr_busy_cpus in the sched_group_power Suresh Siddha
2011-12-06  9:54   ` [tip:sched/core] sched, nohz: Track " tip-bot for Suresh Siddha
2011-12-02  1:07 ` [patch v3 3/6] sched, nohz: sched group, domain aware nohz idle load balancing Suresh Siddha
2011-12-06  6:37   ` Srivatsa Vaddagiri
2011-12-06 19:19     ` Suresh Siddha
2011-12-06 20:24       ` [tip:sched/core] sched, nohz: Fix the idle cpu check in nohz_idle_balance tip-bot for Suresh Siddha
     [not found]     ` <A75BCAD09CE00A4280CDD4429D85F1F9261B42A1F9@orsmsx501.amr.corp.intel.com>
2011-12-06 19:27       ` [patch v3 3/6] sched, nohz: sched group, domain aware nohz idle load balancing Suresh Siddha
2011-12-06  9:54   ` [tip:sched/core] sched, nohz: Implement " tip-bot for Suresh Siddha
2011-12-02  1:07 ` [patch v3 4/6] sched, nohz: cleanup the find_new_ilb() using sched groups nr_busy_cpus Suresh Siddha
2011-12-06  9:55   ` [tip:sched/core] sched, nohz: Clean up " tip-bot for Suresh Siddha
2011-12-02  1:07 ` [patch v3 5/6] sched, ttwu_queue: queue remote wakeups only when crossing cache domains Suresh Siddha
2011-12-02  3:34   ` Mike Galbraith
2011-12-07 16:23     ` Peter Zijlstra
2011-12-07 19:20       ` Suresh Siddha
2011-12-08  6:06         ` Mike Galbraith
2011-12-08  9:41           ` Peter Zijlstra
2011-12-08  9:29         ` Peter Zijlstra
2011-12-08 19:34           ` Suresh Siddha
2011-12-08 21:50             ` Peter Zijlstra
2011-12-08 21:51               ` Peter Zijlstra
2011-12-08 10:02         ` Peter Zijlstra
2011-12-21 11:41           ` [tip:sched/core] sched: Only queue remote wakeups when crossing cache boundaries tip-bot for Peter Zijlstra
2011-12-02  1:07 ` [patch v3 6/6] sched: fix the sched group node allocation for SD_OVERLAP domain Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cd490c5b285544dc1319cf79c2ca0528a6447f61@git.kernel.org \
    --to=suresh.b.siddha@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox