From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755541AbdKBLAg (ORCPT ); Thu, 2 Nov 2017 07:00:36 -0400 Received: from terminus.zytor.com ([65.50.211.136]:56427 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352AbdKBLAf (ORCPT ); Thu, 2 Nov 2017 07:00:35 -0400 Date: Thu, 2 Nov 2017 03:56:01 -0700 From: tip-bot for Andy Lutomirski Message-ID: Cc: peterz@infradead.org, luto@kernel.org, mingo@kernel.org, dave.hansen@intel.com, hpa@zytor.com, bp@suse.de, torvalds@linux-foundation.org, brgerst@gmail.com, bpetkov@suse.de, linux-kernel@vger.kernel.org, tglx@linutronix.de Reply-To: dave.hansen@intel.com, mingo@kernel.org, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, bpetkov@suse.de, linux-kernel@vger.kernel.org, brgerst@gmail.com, torvalds@linux-foundation.org, bp@suse.de, hpa@zytor.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/entry/32: Fix cpu_current_top_of_stack initialization at boot Git-Commit-ID: cd493a6deb8b78eca280d05f7fa73fd69403ae29 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: cd493a6deb8b78eca280d05f7fa73fd69403ae29 Gitweb: https://git.kernel.org/tip/cd493a6deb8b78eca280d05f7fa73fd69403ae29 Author: Andy Lutomirski AuthorDate: Thu, 2 Nov 2017 00:59:15 -0700 Committer: Ingo Molnar CommitDate: Thu, 2 Nov 2017 11:04:47 +0100 x86/entry/32: Fix cpu_current_top_of_stack initialization at boot cpu_current_top_of_stack's initialization forgot about TOP_OF_KERNEL_STACK_PADDING. This bug didn't matter because the idle threads never enter user mode. Signed-off-by: Andy Lutomirski Reviewed-by: Borislav Petkov Cc: Borislav Petkov Cc: Brian Gerst Cc: Dave Hansen Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/e5e370a7e6e4fddd1c4e4cf619765d96bb874b21.1509609304.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/kernel/smpboot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index ad59edd..06c18fe 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -961,8 +961,7 @@ void common_cpu_up(unsigned int cpu, struct task_struct *idle) #ifdef CONFIG_X86_32 /* Stack for startup_32 can be just as for start_secondary onwards */ irq_ctx_init(cpu); - per_cpu(cpu_current_top_of_stack, cpu) = - (unsigned long)task_stack_page(idle) + THREAD_SIZE; + per_cpu(cpu_current_top_of_stack, cpu) = task_top_of_stack(idle); #else initial_gs = per_cpu_offset(cpu); #endif