Re: [patch 20/24] sparc: Use: generic time config

Sam Ravnborg
2012-05-18T18:52:34Z

On Fri, May 18, 2012 at 01:53:35PM -0400, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Fri, 18 May 2012 19:50:41 +0200
>
> > On Fri, May 18, 2012 at 04:45:54PM -0000, Anna-Maria Gleixner wrote:
> >> Index: linux/arch/sparc/Kconfig
> >> ===================================================================
> >> --- linux.orig/arch/sparc/Kconfig
> >> +++ linux/arch/sparc/Kconfig
> >> @@ -30,11 +30,13 @@ config SPARC
> >> select USE_GENERIC_SMP_HELPERS if SMP
> >> select GENERIC_PCI_IOMAP
> >> select HAVE_NMI_WATCHDOG if SPARC64
> >> + select GENERIC_CMOS_UPDATE
> >
> > I do not see where we define the GENERIC_CMOS_UPDATE symbol,
> > so this looks wrong.
> >
> > I looked only in upstream - and I did not look
> > in -tip.
>
> On top of that, I get the impression that this patch series is not
> bisectable at all.

I should be bisectable.

The first patch introduce the symbols with the default value n.
But kconfig will use the "highest" value is see, independent on
the order.

So the following fragment:

config FOO
def_bool y

config FOO
bool

config BAR
bool "BAR"

produces a CONFIG_FOO == y.

And for good measure I also tried with the two
"config FOO" symbols reversed and this produced identical output.

So unless I overlooked something it should be bisectable.

Sam