From: tip-bot for Cyrill Gorcunov <gorcunov@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
gorcunov@openvz.org, tglx@linutronix.de, gorcunov@gmail.com,
mingo@elte.hu
Subject: [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section
Date: Sun, 19 Apr 2009 08:25:51 GMT [thread overview]
Message-ID: <tip-cece3155d869a50ba534ed161b5a05e8a29dcad0@git.kernel.org> (raw)
In-Reply-To: <20090418194528.GD25510@lenovo>
Commit-ID: cece3155d869a50ba534ed161b5a05e8a29dcad0
Gitweb: http://git.kernel.org/tip/cece3155d869a50ba534ed161b5a05e8a29dcad0
Author: Cyrill Gorcunov <gorcunov@gmail.com>
AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 19 Apr 2009 10:22:14 +0200
x86: smpboot - wakeup_secondary should be done via __cpuinit section
A caller (do_boot_cpu) already has __cpuinit attribute.
Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
lead to panic at moment.
[ Impact: cleanup ]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
LKML-Reference: <20090418194528.GD25510@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/smpboot.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index bf8ad63..d2e8de9 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -504,7 +504,7 @@ void __inquire_remote_apic(int apicid)
* INIT, INIT, STARTUP sequence will reset the chip hard for us, and this
* won't ... remember to clear down the APIC, etc later.
*/
-int __devinit
+int __cpuinit
wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
@@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
return (send_status | accept_status);
}
-static int __devinit
+static int __cpuinit
wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
prev parent reply other threads:[~2009-04-19 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 19:45 [PATCH -tip] x86: smpboot - wakeup_secondary should be done via __cpuinit section Cyrill Gorcunov
2009-04-18 21:02 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-18 21:09 ` Yinghai Lu
2009-04-18 21:18 ` Cyrill Gorcunov
2009-04-19 8:25 ` tip-bot for Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-cece3155d869a50ba534ed161b5a05e8a29dcad0@git.kernel.org \
--to=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox